Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

Added support for Web Worker #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

obezuk
Copy link

@obezuk obezuk commented Apr 25, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Developers use Webpack to bundle third party library into Service Workers hosted in Cloudflare Workers. This modification was made to allow bundling Mocha and a developer's unit tests into a Service Worker so they can be executed directly in the Cloudflare Workers runtime.

Mocha's implementation expects either the ability to import unit tests during runtime or file system access which is not available in Service Workers. This modification works around these limitations by importing test files at bundle time.

Breaking Changes

This PR does not introduce any breaking changes and should not impact any existing implementations.

Additional Info

N/A

@jsf-clabot
Copy link

jsf-clabot commented Apr 25, 2019

CLA assistant check
All committers have signed the CLA.

@shagamemnon
Copy link

+1 on getting this merged

2 similar comments
@mw866
Copy link

mw866 commented May 3, 2019

+1 on getting this merged

@sadamia
Copy link

sadamia commented Jun 3, 2019

+1 on getting this merged

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants