Skip to content

Documentation Request #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ecarlisle opened this issue Mar 9, 2017 · 6 comments
Closed

Documentation Request #32

ecarlisle opened this issue Mar 9, 2017 · 6 comments
Assignees

Comments

@ecarlisle
Copy link
Contributor

ecarlisle commented Mar 9, 2017

Hi! I really appreciate source-map-loader! It's definitely a big help in debugging.

I want to understand, however, that it's doing exactly what I think it is. This will help in optimizing my bundling process. Here's my understanding so far:

  1. As a pre-loader, source-map-loader will find the inline and external source maps for all libraries included in a build.
  2. It will process all of these maps into a single map. That map will then be placed into the bundled JavaScript as per the WebPack source map configuration (e.g. cheap-module-eval-source-map, eval-source-map, etc...).

Does this ring true? I'd appreciate any information you can offer and would be happy to place this in a documentation PR in case this is helpful for others.

Thanks!

@michael-ciniawsky
Copy link
Member

@ecarlisle While I can't answer that question 💯 , the initial intro you wrote sounds pretty good so far 👍 when you have time please feel free to a send PR with your writings and additions can be discussed and added later then 😛

@ecarlisle
Copy link
Contributor Author

@michael-ciniawsky : Thank you! I did some testing yesterday and am more confident about my description above. I'll submit a PR asap.

Thanks!

@ecarlisle
Copy link
Contributor Author

Hi!
I finally had a chance to write some copy. Please see the fork here:
https://github.com/ecarlisle/source-map-loader/tree/elaborate-on-primary-documentation
Let me know if you're like to make this into a PR. All feedback, corrections are welcome.

Thanks!
Eric

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Mar 24, 2017

@ecarlisle Open PR 🙃 and corrections can be discussed/corrected there then, looks good, only a few nits in styling 😛 thx very much

@ecarlisle
Copy link
Contributor Author

PR added at #35

@cap-Bernardito
Copy link
Member

PR #37 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants