Skip to content

Elaborate on plugin usage and benefits. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ecarlisle
Copy link
Contributor

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Mar 24, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ecarlisle
❌ Eric Carlisle


Eric Carlisle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Mar 24, 2017

Fixes #32

@michael-ciniawsky
Copy link
Member

@ecarlisle You need to sign the CLA, but there seems to be an error with your email :)

cc @d3viant0ne

@ecarlisle
Copy link
Contributor Author

That's very strange about the e-mail address. I just signed the CLA so hopefully that will process.

@michael-ciniawsky
Copy link
Member

@ecarlisle Are the email adresses in git config and your github profile the same ? If not you need to align them close and reopen the PR to trigger the bot again 😛 . Optimal would be using the one the bot already accepted. Currently the bot thinks, there are two contribs to this PR, because of the eventual address mismatch

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ecarlisle // <=
❌ Eric Carlisle

@ecarlisle
Copy link
Contributor Author

I discovered why the e-mail address was wacky. for whatever reason my .git/config file for my local repo was missing the e-mail address. I updated the config, made a nothing change to the docs and pushed that. Hopefully that will resolve the e-mail address problem. I'm sorry for the confusion.

Let me know if this is easier for me to close this PR and resubmit. This would be the time as we don't have review comments yet.

Thanks!

@michael-ciniawsky
Copy link
Member

When closing and reopening this PR doesn't resolve the issue, you can also close it entirely and resubmit a 'clean' one :)

@ecarlisle
Copy link
Contributor Author

I'm closing this PR and replacing it with #36 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants