Skip to content

WIP: Native workers #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/.babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"useBuiltIns": true,
"targets": {
"node": 4.3
"node": "4.3.0"
},
"exclude": [
"transform-async-to-generator",
Expand Down
14 changes: 8 additions & 6 deletions example/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const path = require('path');
const ExtractTextPlugin = require('extract-text-webpack-plugin'); // eslint-disable-line import/no-extraneous-dependencies
const threadLoader = require('thread-loader'); // eslint-disable-line import/no-extraneous-dependencies
// const threadLoader = require('thread-loader'); // eslint-disable-line import/no-extraneous-dependencies

module.exports = (env) => {
const workerPool = {
Expand All @@ -12,10 +12,12 @@ module.exports = (env) => {
workerParallelJobs: 2,
poolTimeout: env.watch ? Infinity : 2000,
};
if (+env.threads > 0) {
threadLoader.warmup(workerPool, ['babel-loader', 'babel-preset-env']);
threadLoader.warmup(workerPoolSass, ['sass-loader', 'css-loader']);
}

// TODO: fix me
// if (+env.threads > 0) {
// threadLoader.warmup(workerPool, ['babel-loader', 'babel-preset-env']);
// threadLoader.warmup(workerPoolSass, ['sass-loader', 'css-loader']);
// }
return {
context: __dirname,
entry: ['react', 'lodash-es', './index.js'],
Expand All @@ -39,7 +41,7 @@ module.exports = (env) => {
test: /\.scss$/,
use: ExtractTextPlugin.extract({
use: [
env.threads !== 0 && {
false && env.threads !== 0 && {
loader: 'thread-loader',
options: workerPoolSass,
},
Expand Down
211 changes: 211 additions & 0 deletions src/WorkerPool2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,211 @@
/* eslint-disable no-console */
// eslint-disable-next-line
import { Worker } from 'worker_threads';
import asyncQueue from 'async/queue';
import WorkerError from './WorkerError';

const workerPath = require.resolve('./worker2');

let workerId = 0;

class PoolWorker {
constructor(options, onJobDone) {
this.nextJobId = 0;
this.jobs = Object.create(null);
this.activeJobs = 0;
this.onJobDone = onJobDone;
this.id = workerId;
workerId += 1;
this.worker = new Worker(workerPath, {
workerData: {
nodeArgs: options.nodeArgs,
parallelJobs: options.parallelJobs,
},
});

this.worker.on('message', this.onWorkerMessage.bind(this));
this.worker.on('error', console.error);
}

run(data, callback) {
const jobId = this.nextJobId;
this.nextJobId += 1;
this.jobs[jobId] = { data, callback };
this.activeJobs += 1;
this.writeJson({
type: 'job',
id: jobId,
data,
});
}

warmup(requires) {
this.writeJson({
type: 'warmup',
requires,
});
}

writeJson(data) {
const message = {
id: data.id,
type: data.type,
data: {
loaders: data.data.loaders,
resource: data.data.resource,
optionsContext: data.data.optionsContext,
sourceMap: data.data.sourceMap,
},
};

this.worker.postMessage(message);
}

onWorkerMessage(message) {
const { type, id } = message;
switch (type) {
case 'job': {
const { error, result } = message;
const { callback: jobCallback } = this.jobs[id];
const callback = (err, arg) => {
if (jobCallback) {
delete this.jobs[id];
this.activeJobs -= 1;
this.onJobDone();
if (err) {
jobCallback(err instanceof Error ? err : new Error(err), arg);
} else {
jobCallback(null, arg);
}
}
};

if (error) {
callback(this.fromErrorObj(error), result);
return;
}

callback(null, result);
break;
}
case 'resolve': {
const { context, request, questionId } = message;
const { data } = this.jobs[id];
data.resolve(context, request, (error, result) => {
this.writeJson({
type: 'result',
id: questionId,
error: error ? {
message: error.message,
details: error.details,
missing: error.missing,
} : null,
result,
});
});
break;
}
case 'emitWarning': {
const { data } = message;
const { data: jobData } = this.jobs[id];
jobData.emitWarning(this.fromErrorObj(data));
break;
}
case 'emitError': {
const { data } = message;
const { data: jobData } = this.jobs[id];
jobData.emitError(this.fromErrorObj(data));
break;
}
default: {
console.error(`Unexpected worker message ${type} in WorkerPool.`);
break;
}
}
}

fromErrorObj(arg) {
let obj;
if (typeof arg === 'string') {
obj = { message: arg };
} else {
obj = arg;
}
return new WorkerError(obj, this.id);
}

dispose() {
this.worker.terminate();
}
}

export default class WorkerPool {
constructor(options) {
this.options = options || {};
this.numberOfWorkers = options.numberOfWorkers;
this.poolTimeout = options.poolTimeout;
this.workerNodeArgs = options.workerNodeArgs;
this.workerParallelJobs = options.workerParallelJobs;
this.workers = new Set();
this.activeJobs = 0;
this.timeout = null;
this.poolQueue = asyncQueue(this.distributeJob.bind(this), options.poolParallelJobs);
}

run(data, callback) {
if (this.timeout) {
clearTimeout(this.timeout);
this.timeout = null;
}
this.activeJobs += 1;
this.poolQueue.push(data, callback);
}

distributeJob(data, callback) {
// use worker with the fewest jobs
let bestWorker;
for (const worker of this.workers) {
if (!bestWorker || worker.activeJobs < bestWorker.activeJobs) {
bestWorker = worker;
}
}
if (bestWorker && (bestWorker.activeJobs === 0 || this.workers.size >= this.numberOfWorkers)) {
bestWorker.run(data, callback);
return;
}
const newWorker = this.createWorker();
newWorker.run(data, callback);
}

createWorker() {
// spin up a new worker
const newWorker = new PoolWorker({
nodeArgs: this.workerNodeArgs,
parallelJobs: this.workerParallelJobs,
}, () => this.onJobDone());
this.workers.add(newWorker);
return newWorker;
}

warmup(requires) {
while (this.workers.size < this.numberOfWorkers) {
this.createWorker().warmup(requires);
}
}

onJobDone() {
this.activeJobs -= 1;
if (this.activeJobs === 0 && isFinite(this.poolTimeout)) {
this.timeout = setTimeout(() => this.disposeWorkers(), this.poolTimeout);
}
}

disposeWorkers() {
if (this.activeJobs === 0) {
for (const worker of this.workers) {
worker.dispose();
}
this.workers.clear();
}
}
}
Loading