chore(serve): remove promise return from serve package #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
I don't think there is a need for the
servepackage to return a Promise. Users should not be using the package for its API, and it is not logical exactly when the Promise should resolve.As mentioned by @evilebottnawi here: #1011 (comment), there is no need to have an additional
onListening.Does this PR introduce a breaking change?
Yes
Other information