-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
no babel-loader node_modules exclude/web_modules Fixes #1278 #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca92259
to
37acfbd
Compare
and babel@7 so it's safe to do so. also remove web_modules
37acfbd
to
377b146
Compare
I had @nobitagit try this out in IE11 and it works great. |
thank you @sindresorhus for dragging us into the future! |
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 75.72% 75.72%
=======================================
Files 5 5
Lines 482 482
Branches 156 156
=======================================
Hits 365 365
Misses 117 117 Continue to review full report at Codecov.
|
(replying from #1273 (comment)) @julianxhokaxhiu are you sure that's not in your own code? Here's the bundled JS https://unpkg.com/@procensus/[email protected]/client/index.bundle.js |
Yes definitely sure. Feel free to check the project here: https://github.com/julianxhokaxhiu/polysticky.js //EDIT: It seems that downgrading |
@julianxhokaxhiu you've not switched to |
I tested it locally, and it didn't work. So no need to push a commit that is useless. Feel free though to try on your side. Remember that you can try locally by using |
Just to explain why #1273 was needed instead of doing this: the webpack/babel transpilation only affects the bundles used in live mode. When the user uses WDS via the CLI with |
Closing because #1273 fixed the same issue. |
and babel@7 so it's safe to do so.
Fixes #1278
also remove ancient unused version of jquery hiding in
web_modules
.