refactor: setupFeatures method #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
May 15, 2019
| ); | ||
|
|
||
| this.options.setup(app, this); | ||
| this.setupSetupFeature(); |
There was a problem hiding this comment.
Weird name, but we remove this in future so we can leave this as is
alexander-akait
commented
May 15, 2019
| }); | ||
| } else { | ||
| this._watch(contentBase); | ||
| } |
There was a problem hiding this comment.
I see a bug here, when you use string we check on remote, but if you use array we don't check this 
Let's fix it in other PR
There was a problem hiding this comment.
Can you create an issue? (or already existed?)
Codecov Report
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
+ Coverage 87.92% 88.31% +0.38%
==========================================
Files 14 14
Lines 787 813 +26
Branches 259 258 -1
==========================================
+ Hits 692 718 +26
Misses 82 82
Partials 13 13
Continue to review full report at Codecov.
|
2 tasks
|
/cc @hiroppy |
EslamHiko
pushed a commit
to EslamHiko/webpack-dev-server
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no need
Motivation / Use-Case
Refactor
Breaking Changes
No
Additional Info
No