Skip to content

chore(deps): update dependency prettier to ^1.18.2 #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 7, 2019

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies patch ^1.18.0 -> ^1.18.2

Release Notes

prettier/prettier

v1.18.2

Compare Source

diff

v1.18.1

Compare Source

diff

  • TypeScript: Add trailing comma in tsx, only for arrow function (#​6190 by @​sosukesuzuki)

    Prettier inserts a trailing comma to single type parameter for arrow functions in tsx, since v 1.18. But, this feature inserts a trailing comma to type parameter for besides arrow functions too (e.g, function , interface). This change fix it.

    // Input
    interface Interface1<T> {
      one: "one";
    }
    function function1<T>() {
      return "one";
    }
    
    // Output (Prettier stable)
    interface Interface1<T,> {
      one: "one";
    }
    function function1<T,>() {
      return "one";
    }
    
    // Output (Prettier master)
    interface Interface1<T> {
      one: "one";
    }
    function function1<T>() {
      return "one";
    }
  • Config: Match dotfiles in config overrides (#​6194 by @​duailibe)

    When using overrides in the config file, Prettier was not matching dotfiles (files that start with .). This was fixed in 1.18.1


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the renovate label Jun 7, 2019
alexander-akait
alexander-akait previously approved these changes Jun 7, 2019
hiroppy
hiroppy previously approved these changes Jun 7, 2019
@renovate renovate bot dismissed stale reviews from hiroppy and alexander-akait via 5770a2b June 7, 2019 13:39
@renovate renovate bot force-pushed the renovate/patch-all-patch-dependencies branch 2 times, most recently from 5770a2b to 169bd95 Compare June 7, 2019 13:42
hiroppy
hiroppy previously approved these changes Jun 7, 2019
@alexander-akait
Copy link
Member

hm, something wrong with bots 😖

@hiroppy
Copy link
Member

hiroppy commented Jun 7, 2019

Because you pushed this bot's branch 😄 This behavior is default.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1994 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1994   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          28       28           
  Lines        1083     1083           
  Branches      324      324           
=======================================
  Hits         1002     1002           
  Misses         77       77           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce81c69...d35987e. Read the comment docs.

@renovate renovate bot force-pushed the renovate/patch-all-patch-dependencies branch from 169bd95 to 334e895 Compare June 7, 2019 14:09
@alexander-akait
Copy link
Member

Very strange 😕

@hiroppy
Copy link
Member

hiroppy commented Jun 7, 2019

If we modify renovate's pr, renovate will stop commit to its pr.😂

@hiroppy
Copy link
Member

hiroppy commented Jun 7, 2019

I checked the box to rebase from master.

alexander-akait
alexander-akait previously approved these changes Jun 7, 2019
hiroppy
hiroppy previously approved these changes Jun 7, 2019
@renovate renovate bot changed the title chore(deps): update dependency prettier to ^1.18.1 chore(deps): update dependency prettier to ^1.18.2 Jun 7, 2019
@renovate renovate bot dismissed stale reviews from hiroppy and alexander-akait via 811d775 June 7, 2019 15:27
@renovate renovate bot force-pushed the renovate/patch-all-patch-dependencies branch from 334e895 to 811d775 Compare June 7, 2019 15:27
hiroppy
hiroppy previously approved these changes Jun 7, 2019
@renovate renovate bot force-pushed the renovate/patch-all-patch-dependencies branch from 811d775 to d35987e Compare June 8, 2019 16:35
@alexander-akait alexander-akait merged commit a3996ec into master Jun 10, 2019
@alexander-akait alexander-akait deleted the renovate/patch-all-patch-dependencies branch June 10, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants