Skip to content

Prevent application from covering up webpack errors #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2016
Merged

Prevent application from covering up webpack errors #380

merged 1 commit into from
Mar 25, 2016

Conversation

BHSPitMonkey
Copy link
Contributor

Currently, my web application is getting rendered on top of the build errors/warnings, preventing me from seeing them. This CSS change seems to fix it.

Currently, my web application is getting rendered on top of the build errors/warnings, preventing me from seeing them. This CSS change seems to fix it.
@benzen
Copy link

benzen commented Mar 16, 2016

Which is the context in which is affect youy, the inline mode or the iframe mode?

@BHSPitMonkey
Copy link
Contributor Author

@benzen What specifically do you mean? The problem in my case manifested by the <iframe> containing my application being drawn over the webpack error/stacktrace printout; The z-index fix in this patch solved it for me.

@benzen
Copy link

benzen commented Mar 23, 2016

I was wondering if you used this: https://webpack.github.io/docs/webpack-dev-server.html#iframe-mode

@BHSPitMonkey
Copy link
Contributor Author

Ah, I wasn't aware it went by that name. But yes, that's where this bug comes in (the fix I made only affects CSS for the <iframe> element).

@sokra sokra merged commit 2c9a461 into webpack:master Mar 25, 2016
@sokra
Copy link
Member

sokra commented Mar 25, 2016

Thanks

@SpaceK33z SpaceK33z mentioned this pull request Aug 22, 2016
@SpaceK33z
Copy link
Member

Sorry, had to reverse your PR. It caused issues with registering clicks in the iframe itself (#559, and probably #564). If you can find a way that doesn't affect the iframe, a new PR is welcome!

@BHSPitMonkey
Copy link
Contributor Author

We could make it so the webpack messages and the application aren't stacked/positioned in the same place, and just lay them out sequentially?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants