Skip to content

strip ANSI code before sending the message #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

tiye
Copy link
Contributor

@tiye tiye commented Nov 7, 2016

Please check if the PR fulfills these requirements

  • An example has been added or updated in examples/ (for features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

The data passed to sendMsg contains ANSI escape code, which is probably never used by the browser users.

What is the new behavior?

Those escape code are stripped.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Previous context in #481

Other information:

I run the code with my demo and it worked. No further checking.

@jsf-clabot
Copy link

jsf-clabot commented Nov 7, 2016

CLA assistant check
All committers have signed the CLA.

@SpaceK33z
Copy link
Member

After signing the CLA and fixing the wanrings typo this is good to go :).

@tiye
Copy link
Contributor Author

tiye commented Nov 7, 2016

Typo fixed.

@SpaceK33z SpaceK33z merged commit 59345b1 into webpack:master Nov 7, 2016
@SpaceK33z
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants