strip ANSI code before sending the message #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
After signing the CLA and fixing the |
|
Typo fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
examples/(for features)What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
The data passed to
sendMsgcontains ANSI escape code, which is probably never used by the browser users.What is the new behavior?
Those escape code are stripped.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Previous context in #481
Other information:
I run the code with my demo and it worked. No further checking.