Skip to content

Update minimal config example #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2018
Merged

Update minimal config example #2482

merged 2 commits into from
Sep 2, 2018

Conversation

mlsteele
Copy link
Contributor

@mlsteele mlsteele commented Sep 2, 2018

I'm not the first person to forget this import webpack/webpack-dev-server#823 from this page.

@mlsteele
Update minimal config example
29c17a5 
I'm not the first person to forget this import webpack/webpack-dev-server#823
@jsf-clabot
Copy link

jsf-clabot commented Sep 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@montogeek
Copy link
Member

montogeek commented Sep 2, 2018 •
edited
Loading

@byzyk Shouldn't ESLint caught these errors?

@montogeek montogeek merged commit 726cf82 into webpack:master Sep 2, 2018
@montogeek
Copy link
Member

Thanks!

@byzyk
Copy link
Member

byzyk commented Sep 2, 2018

@montogeek it's disabled in the config here since we're missing require statements in a lot of places, not only path but also some plugins etc.

Do you think like we should address that to make examples more complete?

@mlsteele mlsteele deleted the patch-1 branch September 2, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlsteele @jsf-clabot @montogeek @byzyk