Skip to content

Fixing Build Issues #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2016
Merged

Fixing Build Issues #306

merged 3 commits into from
Nov 8, 2016

Conversation

skipjack
Copy link
Collaborator

@skipjack skipjack commented Nov 8, 2016

A fix for a couple build issues, see #305 for related discussion. @SpaceK33z I gotta run to work, but if you could test and get this merged when you have a chance that'd be awesome. I guess we'll also have to do another deployment once this gets merged.

cc @bebraw @TheLarkInn

@SpaceK33z
Copy link
Member

SpaceK33z commented Nov 8, 2016

Clean fix :), the sponsors & backers thingy works great again.

Adding left:0 causes the menu to be left aligned on bigger screens. I think this was meant to only apply for small screens? See screenshot:
webpack

@skipjack
Copy link
Collaborator Author

skipjack commented Nov 8, 2016

Haha yea just realized that too before leaving, see my third commit. Should've fixed it.

@SpaceK33z
Copy link
Member

Awesome! Tested it, and works fine now.

@SpaceK33z SpaceK33z merged commit 19efd33 into develop Nov 8, 2016
@SpaceK33z SpaceK33z deleted the feature/fix-build-issues branch November 8, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants