Migration docs: Changed System.import to import()
#499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added deprecation note. I think describing it with `import()` instead of just `import` will cause less of a headache for newcomers who don't know the difference between `import from` and `import()`.
|
|
prewk
changed the title
System.import to import()System.import to import()
JoshAddington
added a commit
to shapiromatron/hawc
that referenced
this pull request
Jan 6, 2017
Deprecation notice was added with webpack/webpack.js.org#499. Usage of synamic import documented at webpack/webpack.js.org#589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added deprecation note. I think describing it with
import()instead of justimportwill cause less of a headache for newcomers who don't know the difference betweenimport fromandimport().