fix: change 'fetch' script by replacing wildcard with explicit fetch …#7804
Open
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Open
fix: change 'fetch' script by replacing wildcard with explicit fetch …#7804TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@alexander-akait can you please review? |
| "content": "node src/scripts/build-content-tree.mjs ./src/content ./src/_content.json", | ||
| "bundle-analyze": "run-s clean fetch content && webpack --config webpack.prod.mjs --config-node-env production && run-s printable content && webpack --config webpack.ssg.mjs --config-node-env production --env ssg --profile --json > stats.json && webpack-bundle-analyzer stats.json", | ||
| "fetch-repos": "node src/utilities/fetch-package-repos.mjs", | ||
| "fetch": "run-p fetch:*", |
Member
There was a problem hiding this comment.
Weird, it should work, maybe we should use ** here?
Member
There was a problem hiding this comment.
Do you install node_modules?
Contributor
Author
There was a problem hiding this comment.
yeah i do
could yarn version be the case?
i ve 4.12.0
Member
There was a problem hiding this comment.
Very strange, works fine locally
Member
There was a problem hiding this comment.
yes same here. Could you provide OS info and also have you runned yarn install / yarn first?
Contributor
Author
Member
There was a problem hiding this comment.
No, it should work, very strange, maybe you have global installed some packages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixes #7803
Summary
This PR changes
fetchscript by replacing wildcard with explicit fetch scriptsWhat kind of change does this PR introduce?
fix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?