🐛 Knip fails in a git worktree + lefthook

[VanTanev]

Prerequisites

• I'm using the latest version
• I've read the relevant documentation
• I've searched for existing issues
• I've checked the list of known issues
• I've read the issue reproduction guide

Reproduction url

https://github.com/VanTanev/knip-lefthook-bug-reproduction

Reproduction access

• I've made sure the reproduction is publicly accessible

Description of the issue

Reproduction is kind of tedious, because it requires cloning the repo and then creating a git worktree branch checkout.

The issue is that Knip assumes the hooks directory is always .git/hooks, but that is not the case. In a worktree checkout, .git is not a folder but instead a pointer to the real folder.

[altendky]

i ran into this in a related way. my local setup is odd, but it comes down to at least approximately the same failure. i have a git repo in my home directory with **/** in .gitignore. in subdirectories i then have a git worktree setup. when i run knip from the main repo (with a .git directory) it runs without errors as it does for other people. when i run from a worktree (with a .git file) it seems that knip continues outside of the worktree root and finds my home directory .gitignore and ignores the knip configs. deleting my home directory .gitignore results in knip seeing the configs and passing.

tl;dr, likely the same bug, new symptom.

[webpro]

🚀 This issue has been resolved in v5.78.0. See Release 5.78.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

[altendky]

i don't notice a difference in my case. but, perhaps mine is more general or something and needs a new ticket. knip 5.78.0 still traverses outside the worktree root and finds the next higher .gitignore which is entirely unrelated.

$ bun knip --version
5.78.0

$ bun knip
Unused dependencies (9)
@emotion/react       package.json:25:6
@emotion/styled      package.json:26:6
@mui/icons-material  package.json:27:6
@mui/material        package.json:28:6
@mui/utils           package.json:29:6
@next/env            package.json:30:6
react-markdown       package.json:36:6
remark-gfm           package.json:37:6
swr                  package.json:39:6
Unused devDependencies (3)
@testing-library/dom       package.json:44:6
@testing-library/jest-dom  package.json:45:6
@testing-library/react     package.json:46:6
error: "knip" exited with code 1

$ cat ../.git
gitdir: /home/altendky/repos/gw/monorepo/.git/worktrees/kyle-eng-<redacted>

$ mv ../../../../../.gitignore{,.moved}

$ bun knip
✂️  Excellent, Knip found no issues.

[webpro]

Please don't spam other issues with snippets but not an actual repro. Unactionable noise.