Skip to content
This repository was archived by the owner on Aug 23, 2022. It is now read-only.

Refactor out use of anyhow #20

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Refactor out use of anyhow #20

merged 3 commits into from
Oct 8, 2021

Conversation

algesten
Copy link
Member

@algesten algesten commented Oct 6, 2021

This relates to webrtc-rs/webrtc#106

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #20 (444c890) into main (584cb65) will decrease coverage by 0.58%.
The diff coverage is 29.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   61.93%   61.34%   -0.59%     
==========================================
  Files          25       25              
  Lines        2099     2106       +7     
  Branches      533      533              
==========================================
- Hits         1300     1292       -8     
- Misses        398      413      +15     
  Partials      401      401              
Impacted Files Coverage Δ
examples/mdns_query.rs 0.00% <0.00%> (ø)
examples/mdns_server.rs 0.00% <0.00%> (ø)
src/error.rs 0.00% <0.00%> (-60.00%) ⬇️
src/lib.rs 100.00% <ø> (ø)
src/message/question.rs 75.00% <ø> (ø)
src/message/resource/mx.rs 84.21% <ø> (ø)
src/message/resource/ns.rs 100.00% <ø> (ø)
src/message/resource/opt.rs 78.04% <0.00%> (ø)
src/message/resource/ptr.rs 100.00% <ø> (ø)
src/message/resource/soa.rs 64.44% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584cb65...444c890. Read the comment docs.

Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @algesten

@@ -20,8 +20,7 @@ util = { package = "webrtc-util", version = "0.4.3", default-features = false, f
tokio = { version = "1.12.0", features = ["full"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update util to v0.5.0 with new error handling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this change?

@rainliu rainliu merged commit b716a99 into webrtc-rs:main Oct 8, 2021
@algesten algesten deleted the anyhow branch October 8, 2021 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants