Skip to content

Refactor out use of anyhow - #109

Merged
rainliu merged 4 commits into
webrtc-rs:masterfrom
algesten:anyhow
Oct 9, 2021
Merged

rainliu merged 4 commits into
webrtc-rs:masterfrom
algesten:anyhow

Conversation

@algesten

@algesten algesten commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

This relates to #106

Worth noting:

  • I decided to keep anyhow for the examples (making it a dev-dependency).
  • Non of the subcrates git versions are checked in. I'm waiting for @rainliu to release them.
  • There are tests failing on macOS on the master branch. This is the same in the PR.
test data::data_channel::data_channel_test::test_eof_detach has been running for over 60 seconds
test data::data_channel::data_channel_test::test_eof_no_detach has been running for over 60 seconds
test media::dtls_transport::dtls_transport_test::test_peer_connection_dtls_role_setting_engine_client has been running for over 60 seconds
test media::dtls_transport::dtls_transport_test::test_peer_connection_dtls_role_setting_engine_server has been running for over 60 seconds
test media::ice_transport::ice_transport_test::test_ice_transport_get_selected_candidate_pair has been running for over 60 seconds
test media::ice_transport::ice_transport_test::test_ice_transport_on_selected_candidate_pair_change has been running for over 60 seconds
test media::track::track_local::track_local_static_test::test_track_local_static_payload_type has been running for over 60 seconds

Close #106

@algesten
algesten force-pushed the anyhow branch 3 times, most recently from e7b97be to 1e08b84 Compare October 9, 2021 08:14
@rainliu

rainliu commented Oct 9, 2021

Copy link
Copy Markdown
Member

@algesten, thank you for the efforts refactoring all crates' error handling. Last crate to be done. :)

@algesten

algesten commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

@rainliu so close to the finishing line :)

hopefully this passes cleanly now.

@rainliu
rainliu merged commit b6c5e74 into webrtc-rs:master Oct 9, 2021
@algesten
algesten deleted the anyhow branch October 9, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use error enums instead of Anyhow

2 participants