Make RTCPeerConnection::on_track spec-compliant

[alexlapa]

Currently RTCPeerConnection::on_track accepts OnTrackHdlrFn which is:

pub type OnTrackHdlrFn = Box<
    dyn (FnMut(
            Option<Arc<TrackRemote>>,
            Option<Arc<RTCRtpReceiver>>,
        ) -> Pin<Box<dyn Future<Output = ()> + Send + 'static>>)
        + Send
        + Sync,
>;

When according to the WebRTc spec RTCTrackEvent is supposed to be:

interface RTCTrackEvent : Event {
  readonly attribute RTCRtpReceiver receiver;
  readonly attribute MediaStreamTrack track;
  [SameObject] readonly attribute FrozenArray<MediaStream> streams;
  readonly attribute RTCRtpTransceiver transceiver;
};

So, excluding MediaStreams, since i don't see it being used anywhere, this callback is supposed to look like this:

pub type OnTrackHdlrFn = Box<
    dyn (FnMut(
            Arc<TrackRemote>,
            Arc<RTCRtpReceiver>,
            Arc<RTCRtpTransceiver>,
        ) -> Pin<Box<dyn Future<Output = ()> + Send + 'static>>)
        + Send
        + Sync,
>;

[codecov]

Codecov Report

Base: 59.84% // Head: 60.10% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (1099a3d) compared to base (acef878).
Patch coverage: 10.95% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   59.84%   60.10%   +0.25%     
==========================================
  Files         503      503              
  Lines       47652    47983     +331     
  Branches    12358    12492     +134     
==========================================
+ Hits        28516    28838     +322     
- Misses       9905     9920      +15     
+ Partials     9231     9225       -6     

Impacted Files	Coverage Δ
examples/examples/broadcast/broadcast.rs	0.00% <0.00%> (ø)
examples/examples/reflect/reflect.rs	0.00% <0.00%> (ø)
examples/examples/rtp-forwarder/rtp-forwarder.rs	0.00% <0.00%> (ø)
...es/examples/save-to-disk-h264/save-to-disk-h264.rs	0.00% <0.00%> (ø)
...ples/examples/save-to-disk-vpx/save-to-disk-vpx.rs	0.00% <0.00%> (ø)
examples/examples/simulcast/simulcast.rs	0.00% <0.00%> (ø)
examples/examples/swap-tracks/swap-tracks.rs	0.00% <0.00%> (ø)
.../src/rtp_transceiver/rtp_sender/rtp_sender_test.rs	55.14% <9.37%> (+0.82%)	⬆️
webrtc/src/peer_connection/peer_connection_test.rs	63.56% <41.66%> (+0.61%)	⬆️
.../rtp_transceiver/rtp_receiver/rtp_receiver_test.rs	57.69% <50.00%> (+0.41%)	⬆️
... and 106 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alexlapa]

Compile and test with minimal versions CI step also fails on current master, so i don't think it is relevant to this PR.

[k0nserv]

Noice 👍🏼