[SCTP] improve payload queue push performance #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 59.99% // Head: 59.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 59.99% 59.97% -0.03%
==========================================
Files 504 504
Lines 48068 48070 +2
Branches 12517 12519 +2
==========================================
- Hits 28838 28828 -10
- Misses 10011 10019 +8
- Partials 9219 9223 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
KillingSpark
changed the title
melekes
reviewed
Dec 21, 2022
| self.length.fetch_add(1, Ordering::SeqCst); | ||
| self.update_sorted_keys(); |
|
Sorry I must have made a mistake, the tests started failing. I'll fix it soon Fixed 👍 |
…the tsn does not match
melekes
reviewed
Dec 22, 2022
melekes
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #360 Gathering packets to send is a big chunk of the work the Association::write_loop is doing while in a critical section.
This PR improves the performance of this by making the payload queue more performant to push to.
Previously this did a full mergesort (O(n*log(n))) on all the in-flight TSNs, now it does a binary search (O(log(n)))