-
-
Notifications
You must be signed in to change notification settings - Fork 413
Make RTCRtpTransceiver.mid spec-compliant #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @k0nserv |
Codecov ReportBase: 60.14% // Head: 61.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 60.14% 61.12% +0.98%
==========================================
Files 503 537 +34
Lines 47987 49620 +1633
Branches 12501 12590 +89
==========================================
+ Hits 28860 30330 +1470
- Misses 9911 9968 +57
- Partials 9216 9322 +106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent change 🎉
Just a few comments
@rogurotus I'm sorry, I'm a doofus, we can't use Instead of it can you use match as let x = match y {
//Positive match yields value,
_ => continue; // or break/return etc
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current implementation is:
Essentially, the empty string is used instead of
None
(Option<String>
).This PR makes the behavior of
mid
explicitly optional, and also replacesMutex
withOnceCell
.