Revert "Fix cargo fmt error"
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
fixing some of clippy's issues + converting comments to doc comments
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
Don't reallocate the read buffer on every read in
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
on MacOS because they take too long to complete for some reason. Will need to be investigated later on.
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
* update deps + loosen some requirements
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
* update util version
algesten
pushed a commit
that referenced
this pull request
Aug 23, 2022
rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
then you should specify 0.3.17, which actually means "0.3.y where y >=
17"
- for crates the are above or equal v1.0 -> specify only major version
if the crate's API is minimal and won't change between minor versions
OR specify major&minor versions otherwise
tested with https://github.com/taiki-e/cargo-minimal-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7