[Windows] Fixed the audio capture issue when the built-in AEC enabled #23
Conversation
…e mic cannot be captured when StartRecording is called before StartPlayout.
cloudwebrtc
changed the title
cloudwebrtc
changed the title
cloudwebrtc
changed the title
|
Hey, can you do this against the m97_release branch? Main is the old m93 release. |
|
sure, I forgot about this. xD |
| @@ -2356,7 +2356,7 @@ int32_t AudioDeviceWindowsCore::StartRecording() { | |||
| } | |||
| } | |||
|
|
|||
| RTC_DCHECK(_hRecThread); | |||
| RTC_DCHECK(_hRecThread == NULL); | |||
There was a problem hiding this comment.
Looks like this is fixed in m97.
| @@ -2493,7 +2493,7 @@ int32_t AudioDeviceWindowsCore::StartPlayout() { | |||
| MutexLock lockScoped(&mutex_); | |||
|
|
|||
| // Create thread which will drive the rendering. | |||
| RTC_DCHECK(_hPlayThread); | |||
| RTC_DCHECK(_hPlayThread == NULL); | |||
There was a problem hiding this comment.
Looks like this is fixed in m97.
| if (!adm->PlayoutIsInitialized()) { | ||
| adm->InitPlayout(); | ||
| } | ||
| adm->StartPlayout(); |
There was a problem hiding this comment.
Could you write a comment explaining why this is needed? Seems weird to require playout for recording.
There was a problem hiding this comment.
The problem is caused here https://github.com/webrtc-sdk/webrtc/blob/main/modules/audio_device/win/audio_device_core_win.cc#L2353. If the built-in AEC is enabled, opening the Recording alone will fail to create hRecThread, resulting in no sound captured by the send stream.
But if StartPlayOut is called early, it works both ways.
There was a problem hiding this comment.
I think the code here is a bit strange, with the built-in AEC enabled, recording/playout cannot be started independently. ,
|
new PR here. #29 |
Fixed the issue when the built-in AEC is valid under Windows, the mic cannot be captured when StartRecording is called before StartPlayout.
Trigger conditions for this bug:
1, windows and supports built-in AEC enabled
2. StartRecording is called before StartPlayOut, such as SendOnly mode, or AudioSendStream is enabled before AudioRecvStream
The raised issue, unable to capture mic and no audio stream sent