Skip to content

Improve H264 encoder #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroshihorie merged 13 commits into from
May 22, 2023
Merged

Improve H264 encoder #70

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c005df9
progress
hiroshihorie May 18, 2023
8ce2df8
enable low-latency video encoding
hiroshihorie May 19, 2023
7892c03
fix compile
hiroshihorie May 19, 2023
062d40d
prioritize speed
hiroshihorie May 19, 2023
8ba74bf
fix required os versions
hiroshihorie May 19, 2023
726fb9e
maxQP for screensharing
hiroshihorie May 20, 2023
ea7db41
cbr
hiroshihorie May 21, 2023
54aabc3
Update RTCVideoEncoderH264.mm
hiroshihorie May 21, 2023
808223b
Update RTCVideoEncoderH264.mm
hiroshihorie May 21, 2023
b4ad069
format
hiroshihorie May 21, 2023
67fb003
clean up
hiroshihorie May 22, 2023
bfd99df
resolution alignment
hiroshihorie May 22, 2023
4d21a6f
revert resolution alignment
hiroshihorie May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sdk/objc/native/src/objc_video_track_source.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,14 @@ - (void)capturer:(RTC_OBJC_TYPE(RTCVideoCapturer) *)capturer

ObjCVideoTrackSource::ObjCVideoTrackSource() : ObjCVideoTrackSource(false) {}

#if defined(WEBRTC_ANDROID)
constexpr int kResolutionAlignment = 16;
#else
constexpr int kResolutionAlignment = 2;
#endif

ObjCVideoTrackSource::ObjCVideoTrackSource(bool is_screencast)
: AdaptedVideoTrackSource(/* required resolution alignment */ is_screencast? 16 : 2),
: AdaptedVideoTrackSource(/* required resolution alignment */ kResolutionAlignment),
is_screencast_(is_screencast) {}

ObjCVideoTrackSource::ObjCVideoTrackSource(RTCObjCVideoSourceAdapter *adapter) : adapter_(adapter) {
Expand Down