Skip to content

Environment variable name update: WECHATY_PUPPET_SERVICE_ENDPOINT #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huan opened this issue Oct 29, 2021 · 2 comments
Closed

Environment variable name update: WECHATY_PUPPET_SERVICE_ENDPOINT #14

huan opened this issue Oct 29, 2021 · 2 comments
Assignees
@zhangchunsheng

Comments

@huan
Copy link
Member

huan commented Oct 29, 2021

We have updated the HOSTIE name to SERVICE, and so does in the code class/variable names. (i.e. PuppetHostie -> PuppetService)

- WECHATY_PUPPET_HOSTIE_ENDPOINT
+ WECHATY_PUPPET_SERVICE_ENDPOINT
- PuppetHostie
- PuppetService
- wechaty-puppet-hostie
+ wechaty-puppet-service
@huan huan changed the title Environment variable update: WECHATY_PUPPET_SERVICE_ENDPOINT Environment variable name update: WECHATY_PUPPET_SERVICE_ENDPOINT Oct 29, 2021
@zhangchunsheng zhangchunsheng self-assigned this Oct 29, 2021
@zhangchunsheng
Copy link
Member

What about the url "https://api.chatie.io/v0/hosties"?

I think this url need to be changed.

zhangchunsheng added a commit that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see #14
df0a7d2
zhangchunsheng added a commit that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see #14
e4b8f66
@huan
Copy link
Member Author

huan commented Nov 24, 2021

The server API will not be changed because it will cause unnecessary breaking changes.

In TypeScript, we have a Wechaty gRPC Resolver for encapsulating this logic, please refer to the source code and see if it can inspire the PHP.

https://github.com/wechaty/token/blob/main/src/wechaty-token.ts

zhangchunsheng added a commit that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see #14
b32b96d
zhangchunsheng added a commit to wechaty/php-wechaty-getting-started that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
918ddfd
zhangchunsheng added a commit to wechaty/docker-php-wechaty-getting-started that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
e1b12ee
zhangchunsheng added a commit to drelp/glaze-dockerfile that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
b5cfa8f
zhangchunsheng added a commit to wechaty/docker-php-wechaty-getting-started that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
3ea8791
zhangchunsheng added a commit to wechaty/docker-php-wechaty-getting-started that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
74875ba
zhangchunsheng added a commit to wechaty/php-wechaty-getting-started that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see wechaty/php-wechaty#14
a50a2ea
zhangchunsheng added a commit that referenced this issue Nov 24, 2021
@zhangchunsheng
update hostie to service, see #14
2c5ace8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangchunsheng zhangchunsheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhangchunsheng @huan