[WIP] fixing the unit tests #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Abstract aggregate listener | ||
| */ | ||
| abstract class AbstractListenerAggregate implements ListenerAggregateInterface | ||
| { |
There was a problem hiding this comment.
We should likely keep this class, as there are extensions to it. We can simply remove the detach() implementation, though. I'll take care of that on merge.
weierophinney
added a commit
that referenced
this pull request
Sep 17, 2015
[WIP] fixing the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to fix the unit tests according with the changes introduced in zendframework#4. I started to fix the unit tests and I commented the lines that generate fatal errors.