Skip to content

Hotfix/resolve timeout issues #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cr7boulos wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hotfix/resolve timeout issues #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fd44d
#33 resolves timeout issue
Oct 8, 2020
48aa951
bump version; disable navigation timeout
Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pdf-puppeteer",
"version": "1.1.10",
"version": "1.1.11",
"description": "A simple NPM package to convert html to pdf for Node applications by using Puppeteer",
"main": "index.js",
"types": "index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/convertHTMLToPDF.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ let convertHTMLToPDF = async (html, callback, options = null, puppeteerArgs=null

if (remoteContent === true) {
await page.goto(`data:text/html;base64,${Buffer.from(html).toString('base64')}`, {
waitUntil: 'networkidle0'
waitUntil: 'networkidle0',
'timeout': 0
});
} else {
//page.setContent will be faster than page.goto if html is a static
Expand Down