Skip to content

Specify default passive for document-level wheel/mousewheel/touchstart/touchmove events #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 16, 2022

Fixes #365.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@zcorpan
Copy link
Member Author

zcorpan commented Jun 16, 2022

This depends on whatwg/html#8017 (edit: is merged now)

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! It's great to see this being tackled.

I found a couple nits and one more substantive issue.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 17, 2022

@annevk thanks, fixed

@annevk
Copy link
Member

annevk commented Jun 17, 2022

I was going to merge this, but then I realized the tests might not be ready yet?

Suggested commit message:

Default passive for wheel/mousewheel/touchstart/touchmove events

In particular when the event listener is added on a Window object, Document object, document element, or the body element.

Tests: https://github.com/web-platform-tests/wpt/pull/34464.

Fixes #365.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 17, 2022

Yeah, the tests still need review.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 28, 2022

I've opened two wpt PRs:

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jun 30, 2022
@zcorpan zcorpan merged commit b294497 into main Jun 30, 2022
@zcorpan zcorpan deleted the bocoup/passive-default branch June 30, 2022 08:30
@annevk
Copy link
Member

annevk commented Jun 30, 2022

Note that the reason I suggested the commit message above is because the one used isn't correct per https://github.com/whatwg/meta/blob/main/COMMITTING.md. Please keep that in mind for next time.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 30, 2022

Oops, sorry about that.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 5, 2022
…passive by default, a=testonly

Automatic update from web-platform-tests
DOM: Test that some event listeners are passive by default

Follows whatwg/dom#1087
--

wpt-commits: f1c5bcd1613a7d7d35d07b3edc4e4aef7fc815d1
wpt-pr: 34623
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jul 7, 2022
…passive by default, a=testonly

Automatic update from web-platform-tests
DOM: Test that some event listeners are passive by default

Follows whatwg/dom#1087
--

wpt-commits: f1c5bcd1613a7d7d35d07b3edc4e4aef7fc815d1
wpt-pr: 34623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow an EventTarget to provide the default value of the AddEventListenerOptions
2 participants