-
Notifications
You must be signed in to change notification settings - Fork 307
Specify default passive for document-level wheel/mousewheel/touchstart/touchmove events #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t/touchmove events Fixes #365.
This depends on whatwg/html#8017 (edit: is merged now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! It's great to see this being tackled.
I found a couple nits and one more substantive issue.
@annevk thanks, fixed |
I was going to merge this, but then I realized the tests might not be ready yet? Suggested commit message:
|
Yeah, the tests still need review. |
I've opened two wpt PRs:
|
Note that the reason I suggested the commit message above is because the one used isn't correct per https://github.com/whatwg/meta/blob/main/COMMITTING.md. Please keep that in mind for next time. |
Oops, sorry about that. |
…passive by default, a=testonly Automatic update from web-platform-tests DOM: Test that some event listeners are passive by default Follows whatwg/dom#1087 -- wpt-commits: f1c5bcd1613a7d7d35d07b3edc4e4aef7fc815d1 wpt-pr: 34623
…passive by default, a=testonly Automatic update from web-platform-tests DOM: Test that some event listeners are passive by default Follows whatwg/dom#1087 -- wpt-commits: f1c5bcd1613a7d7d35d07b3edc4e4aef7fc815d1 wpt-pr: 34623
Fixes #365.
mousewheel
event is not supported), Chromium, WebKit(See WHATWG Working Mode: Changes for more details.)
Preview | Diff