Remove unnecessary body transmission for service worker trapped requests #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this cause XMLHttpRequest upload progress events to not dispatch? |
|
This is the service worker intercept case, and transmitting the body to network makes no sense at all. Can we fix the upload progress issue separately? |
|
Transmit body doesn't necessarily mean a network transmission. It can be from one process to another. If you run blame on this line I think you'll find we added this for XHR. |
|
Ah, I misunderstood, thank you. I'll abandon this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the request is trapped by service worker, there is no need to transmit the body to network.
See #572 for more info.
Preview | Diff