Skip to content

Navigation API: fix an ordering issue #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Navigation API: fix an ordering issue #11512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad24dcd
Navigation API: fix an ordering issue
domenic Jul 31, 2025
a33a02d
Also fix missing word from previous PR
domenic Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96378,15 +96378,15 @@ const p2 = navigation.navigate(url2).finished;</code></pre>
0.</p>
</li>

<li><p>If <var>navigation</var>'s <span>ongoing API method tracker</span> is non-null, then
<span>reject the finished promise</span> for <var>apiMethodTracker</var> with
<var>error</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigateerror">navigateerror</code> at <var>navigation</var> using
<code>ErrorEvent</code>, with additional attributes initialized according to
<var>errorInfo</var>.</p></li>

<li><p>If <var>navigation</var>'s <span>ongoing API method tracker</span> is non-null, then
<span>reject the finished promise</span> for <var>apiMethodTracker</var> with
<var>error</var>.</p></li>

<li>
<p>If <var>navigation</var>'s <span data-x="concept-Navigation-transition">transition</span> is
not null, then:</p>
Expand Down Expand Up @@ -97242,7 +97242,7 @@ interface <dfn interface>NavigationDestination</dfn> {
</ol>

<div class="note">
<p>If there is an ongoing cross-document navigation, this means it will signaled to the
<p>If there is an ongoing cross-document navigation, this means it will be signaled to the
navigation API as aborted, e.g., by firing <code
data-x="event-navigateerror">navigateerror</code> events. This is somewhat accurate, since
the next navigation the <code>Document</code> experiences will be this same-document
Expand Down Expand Up @@ -97720,12 +97720,12 @@ interface <dfn interface>NavigationDestination</dfn> {
<li><p><span data-x="NavigateEvent-finish">Finish</span> <var>event</var> given
true.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigatesuccess">navigatesuccess</code> at <var>navigation</var>.</p></li>

<li><p>If <var>apiMethodTracker</var> is non-null, then <span>resolve the finished
promise</span> for <var>apiMethodTracker</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigatesuccess">navigatesuccess</code> at <var>navigation</var>.</p></li>

<li><p>If <var>navigation</var>'s <span
data-x="concept-Navigation-transition">transition</span> is not null, then resolve
<var>navigation</var>'s <span data-x="concept-Navigation-transition">transition</span>'s
Expand Down Expand Up @@ -97759,14 +97759,14 @@ interface <dfn interface>NavigationDestination</dfn> {
<li><p>Let <var>errorInfo</var> be the result of <span data-x="extract-error">extracting error
information</span> from <var>rejectionReason</var>.</p></li>

<li><p>If <var>apiMethodTracker</var> is non-null, then <span>reject the finished
promise</span> for <var>apiMethodTracker</var> with <var>rejectionReason</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigateerror">navigateerror</code> at <var>navigation</var> using
<code>ErrorEvent</code>, with additional attributes initialized according to
<var>errorInfo</var>.</p></li>

<li><p>If <var>apiMethodTracker</var> is non-null, then <span>reject the finished
promise</span> for <var>apiMethodTracker</var> with <var>rejectionReason</var>.</p></li>

<li><p>If <var>navigation</var>'s <span
data-x="concept-Navigation-transition">transition</span> is not null, then reject
<var>navigation</var>'s <span data-x="concept-Navigation-transition">transition</span>'s
Expand Down