Imply [Reflect] when [ReflectRange] or [ReflectDefault] are used. #11518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lukewarlow
force-pushed
the
implicit-reflect
branch
from
5c5bfa1 to
4989cc8
Compare
This allows reducing noise in the IDL for the common case that no argument needs passing to [Reflect].
lukewarlow
force-pushed
the
implicit-reflect
branch
from
4989cc8 to
ad3b725
Compare
annevk
reviewed
Aug 1, 2025
| <p>To supplement the above <span data-x="extended attribute">extended attributes</span> we also | ||
| introduce <dfn extended-attribute data-lt="ReflectRange" | ||
| <p>To supplement the above <span data-x="extended attribute">extended attributes</span> <dfn | ||
| extended-attribute data-lt="ReflectRange" | ||
| data-x="xattr-ReflectRange"><code>[ReflectRange]</code></dfn>, and <dfn extended-attribute |
There was a problem hiding this comment.
Drop the comma here as there's only two alternatives.
| any primary <span data-x="reflect">reflection</span> <span>extended attribute</span> except <code | ||
| data-x="xattr-Reflect">[Reflect]</code>. If there is no primary <span | ||
| data-x="reflect">reflection</span> <span>extended attribute</span> then, <code | ||
| data-x="xattr-Reflect">[Reflect]</code> with no argument is implied.</p> |
There was a problem hiding this comment.
Perhaps we can constrain it even further to only allow Reflect when its identifier is present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imply [Reflect] when [ReflectRange] or [ReflectDefault] are used.
This allows reducing noise in the IDL for the common case that no argument needs passing to [Reflect].
Based on suggestion in #11455 (comment)
(See WHATWG Working Mode: Changes for more details.)