Make event handlers share a code path with addEventListener() #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/dom#596 and whatwg/dom#365 and w3c/ServiceWorker#1004 for more context.
annevk
added
normative change
integration
|
@domenic I aligned this with the approved DOM PR. Would be nice to land them both at the same time I think. |
domenic
approved these changes
Mar 14, 2018
| <var>callback</var>.</p> | ||
|
|
||
| <p class="note">To be clear, an <span>event listener</span> is different from an <code | ||
| data-x="dom-EventListener">EventListener</code>.</p> |
There was a problem hiding this comment.
I think this will get some laughs from future readers :)
|
We should have tests for the normative change aspects of this I guess? Which are related to service workers? |
|
Yeah, I was wondering about that. See also whatwg/dom#371 (comment). I'm kind of inclined to land this now and leave testing for that issue, mostly because DOM is seeing many changes at the moment and dealing with merge conflicts is not my favorite. |
|
Yeah, testing this when you fix 371 makes sense. |
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Mar 14, 2018
This hook ensures that any special casing in addEventListener() is shared with event handlers. This commit also makes numerous editorial improvements that were long overdue around dictionary members. The corresponding change to the HTML Standard, which defines event handlers, is tracked by whatwg/html#3561. This helps with #365 and w3c/ServiceWorker#1004. (Tests will be added as part of #365 eventually.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/dom#596 and whatwg/dom#365 and w3c/ServiceWorker#1004 for more context.
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )