Skip to content

Allow implementations to kill worklets whenever, by default #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Allow implementations to kill worklets whenever, by default #6072

merged 1 commit into from
Oct 19, 2020

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 16, 2020 •
edited by pr-preview bot
Loading

Closes w3c/css-houdini-drafts#470.

  • At least two implementers are interested (and none opposed):
    • This seems to reflect a robust multi-implementer consensus among Houdini folks, per the linked issue
  • Tests are written and can be reviewed and commented upon at:
    • This is not testable.
  • Implementation bugs are filed:
    • Not needed

(See WHATWG Working Mode: Changes for more details.)

/worklets.html ( diff )

domenic added a commit to domenic/web-audio-api that referenced this pull request Oct 16, 2020
@domenic
Prohibit arbitrary termination of AudioWorkletGlobalScopes
ab5af97 
Part of w3c/css-houdini-drafts#470 and whatwg/html#6072.
@domenic domenic mentioned this pull request Oct 16, 2020
Merged
annevk
annevk approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this makes the default type of worklet stateless? Once we have a couple worklets maybe we should try to abstract some of their logic so it's less wishy-washy at this level.

@domenic domenic merged commit f703a2c into master Oct 19, 2020
@domenic domenic deleted the worklet-nondeterministic-lifetime branch October 19, 2020 15:18
rtoy pushed a commit to WebAudio/web-audio-api that referenced this pull request Oct 28, 2020
@domenic
Prohibit arbitrary termination of AudioWorkletGlobalScopes (#2266)
f15a957 
Part of w3c/css-houdini-drafts#470 and whatwg/html#6072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
topic: worklets
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-paint-api] Are PaintWorkletGlobalScopes allowed to go away?
2 participants
@domenic @annevk