Skip to content

refactor CommitInstantiated to a "method" of registry entry #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dherman opened this issue Aug 28, 2015 · 3 comments
Closed

refactor CommitInstantiated to a "method" of registry entry #79

dherman opened this issue Aug 28, 2015 · 3 comments
Labels

Comments

@dherman
Copy link

dherman commented Aug 28, 2015

CommitInstantiated is a weird and confusing abstract operation. Its real purpose is to flesh out the internal state of a registry entry record. This would be a little easier to understand if it were a spec "method" of a registry entry record. Also, it should have a better name.

To be clear, registry entry records are not JS objects, so I'm not talking about a JS method. But ECMA 262 does have a precedent for internal records of the semantics having methods on them.

Something like:

1. Let _status_ be _entry_.ExtractInstanceDependencies(_loader_, _optionalInstance_, _source_).

or maybe split it into two separate operations like:

1. Let _status_ be _entry_.ExtractInstance(_loader_, _optionalInstance_, _source_).
1. ReturnIfAbrupt(_status_).
1. _entry_.ExtractDependencies().

Something like that...

@dherman dherman added the bug label Aug 28, 2015
@caridy
Copy link
Contributor

caridy commented Aug 28, 2015

Could they be just abstract methods of Registry Objects? Just like we did for Module Objects?

@caridy
Copy link
Contributor

caridy commented Oct 23, 2015

This is part of #97

@caridy
Copy link
Contributor

caridy commented Dec 1, 2015

fixed by #97

@caridy caridy closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants