-
Notifications
You must be signed in to change notification settings - Fork 47
Upgrade path to Pydantic 2.0 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Major path updates include: - frontend: - Node 16 to 18 - Latest Pinia requires changes in `stores`, where imports are not required, and parameter declaration must happen in functions. - backend and celeryworker: - Python 3.9 to 3.11 - Poetry to Hatch - Postgres 14 to 15
Getting this error on
|
Celeryworker fix: Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead. Frontend: Weird issue with latest version of Vite: #35 Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
The fix to |
Fixing Pinia referencing changes and standardising naming conventions
- Token invalid settings seems somewhat pointless ... just remove it entirely to avoid risk of weird conflicts - Simplified crud paging with a site-level setting ... risk of some sort of DoS attack by having a way to bypass row-fetch limits - Placeholder for a sockets-based API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turukawa. Great to see Hatch and inboard put to good use here. I have a few suggestions. Feel free to let me know if any further clarifications or changes are needed.
Co-authored-by: Brendon Smith <[email protected]>
Co-authored-by: Brendon Smith <[email protected]>
Celeryworker fix: Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead. Frontend: Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35 Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
Major path updates include:
frontend
:stores
, where imports are not required (cause actual errors), and parameter declaration must happen in functions.backend
andceleryworker
:Review required on the new
hatch
pyproject.toml
file, and to ensure that the environments are stable. @br3ndonland, I'd appreciate your review.