-
Notifications
You must be signed in to change notification settings - Fork 205
add multimodal support #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nph4rd
wants to merge
50
commits into
willccbb:main
Choose a base branch
from
nph4rd:multimodal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass mm kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multimodal support. Main changes are:
data_collator
. I think this is useful because different VLMs have different processing requirements/tooling. For instance, in the case of Qwen, you can useqwen_vl_utils
to handle resizing, etc.format_oai_chat_msg
for the rollouts. This handles encoding them as base64 imgs for the API, but leaves the image objects for further processing later on.process_chat_format
now has two branches: the multimodal case uses theprocessing_class
to get the all the extra inputs necessary. These vary from model to model, so they are generically captured byremaining_inputs
. I'm still unsure this is the best way to handle that, but this works.processing_class
. This can now be either a multimodal processor (with thetokenizer
attr) or a tokenizer in the text-only case.logits_to_keep
. Not all models accept this.generic_model_loader
function to load models without handling specific classes (likeQwen2_5_VLForConditionalGeneration
)AutoLigerKernelForCausalLM
Notes: