Add arduino-language-server support #298
Conversation
thetic
changed the title
lua/nvim-lsp-installer/servers/arduino_language_server/init.lua
Outdated
Show resolved
Hide resolved
lua/nvim-lsp-installer/servers/arduino_language_server/init.lua
Outdated
Show resolved
Hide resolved
|
I opened an issue on the server to mimic |
There was a problem hiding this comment.
Nice work 🎯! I think this looks good now. This is installing 3 different components atm, and because there are no builtin APIs to help with this, they all install to the same directory. I mention it in another comment earlier, but I'd like to make that possible before merging this. Will look into it asap and push any necessary changes
* origin/main: add ccls (williamboman#299) sumneko_lua: don't provide -E argument as it's not needed (williamboman#309) fix(angularls): also provide `cmd` property fix(installers/shell): pass script via arg, when possible (williamboman#307)
|
@thetic I added a commit that makes sure to install the CLI and LSP to separate directories. Could you see if things still work for you? I also removed the arch check for Mac, because it seems like it starts just fine on my arm Mac (although I couldn't really get any diagnostics or go to definition working in a sample project I found on GitHub, but I might be doing something wrong). |
|
This isn't working for me. I wonder if clangd is indeed required. |
Did my commits break things, or was it not working before either? |
|
I'm investigating now. |
|
Disregard. I'm running into limitations of the actual server it seems. Installation is working as expected. |
Yeah the server seems to not really do anything? Let's merge this for now, I'd be happy to bundle clangd at a later point if it turns out to make sense to do so |
* origin/main: Add arduino-language-server support (#298)
* main: fix(quick_lint_js): use latest dist instead of collecting it via github API (#319) tag eslint with javascript & typescript fix(quick_lint_js): account for the fact that the archive has different structures across platforms (#315) fix installing arduino_language_server on Windows fix(quick_lint_js): use correct release files (#314) add quick_lint_js (#313) Add arduino-language-server support (#298) feat: use vim.ui.select to prompt which server to install
* main: (47 commits) feat: allow server installation by just typing `:LspInstall` (#331) .github: update new server request template add solidity_ls language server (#296) fix: zls-0.2 uses a different archive path (#330) better healthchecks with min version check stylua fix: increase timeout for sync installs to 60 minutes fix(angularls): fix --ngProbeLocation (#323) README: add link to Rust Wiki page add spectral (#295) add :PylspInstall command for managing 3rd party pylsp plugins (#318) initial healthcheck integration (#321) fix(installers/npm): dont apply global-style for standalone npm install fix(quick_lint_js): use latest dist instead of collecting it via github API (#319) tag eslint with javascript & typescript fix(quick_lint_js): account for the fact that the archive has different structures across platforms (#315) fix installing arduino_language_server on Windows fix(quick_lint_js): use correct release files (#314) add quick_lint_js (#313) Add arduino-language-server support (#298) ...
Address #292
This is far from finished.
arduino-cli.exe(vsarduino-cli) on Windowsarduino-cliversion when installingarduino-language-server.clangd. Can this depend on the existing installer somehow?References