Fix for RefResolutionError on Windows caused by backslashes in schema_dir #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @willthames, could you take a look at this PR? |
luukdobber
force-pushed
the
fix-windows
branch
from
20b5333 to
06dbf53
Compare
willthames
approved these changes
Mar 24, 2021
|
Thanks @luukdobber, and apologies for the delay. I'll get this released in the next day or two |
|
This fix is in 1.20, just released to pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, kubernetes-validate raises a RefResolutionError while trying to resolve the
$ref's in schema files. This is caused by back slashes in theschema_dirpath on Windows. Converting these back slashes to forward slashes resolves the error on Windows. I've also tested the change on macOs.More about this issue: python-jsonschema/jsonschema#98 (comment)