Skip to content

Comments

Fixing metadata storing#219

Merged
DABH merged 10 commits intowinstonjs:masterfrom
sovcik:master
Jul 10, 2023
Merged

Fixing metadata storing#219
DABH merged 10 commits intowinstonjs:masterfrom
sovcik:master

Conversation

@sovcik
Copy link
Contributor

@sovcik sovcik commented Jun 12, 2023

  1. added dotenv as dev-dependency for easier testing
  2. originally I wanted to fix dts too, so it won't be necessary to provide Promise with connected mongo-client, but left it as it is
  3. fixed (I hope I understood your intention correctly) metadata storing - winston sends whole info object and metadata is everything besides label and message
  4. fixed metadata key - you could provide a new name as an option, but was stored always as meta

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. It's been a while since I looked at all the metadata stuff, but I do think this was the intent. Thank you for your contributions!

@DABH DABH merged commit 9d81162 into winstonjs:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants