Merged
Conversation
By default, mongodb-memory-server pulls in a MongoDB binary on install. On a first run of 'npm ci', this makes npm seem to hang for no reason. No progress bar or anything is shown either. With this change, the MongoDB binary is only downloaded when needed. If needed, the download happens during tests, with progress indication. No download will happen for people using local Mongo for testing.
DABH
approved these changes
Jul 13, 2023
Contributor
DABH
left a comment
DABH
left a comment
There was a problem hiding this comment.
This is fantastic! Thank you for this critical and valued contribution to the transport ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #225.
I strongly suggest going commit by commit.
My approach to the linting fixes: