Conversation
|
@DABH Is it possible to merge this PR? |
|
I can merge this but need to think about versioning. Since default options are changing, this feels like it should be a major version release of |
|
@DABH, I agree. |
|
Sure. No problem. |
|
@Bharat94389 Any chance you can rebase this PR so I can merge it? (Or any other volunteers?) |
|
@DABH updated the PR please have a look |
|
@Bharat94389 Thanks for updating! It looks like there's now a test failure that doesn't occur on master. Perhaps you have to just do |
|
@DABH tried installing ip globally but didn't work so added as a dev package, and ran all the testcases locally as well. |
|
Whoops, don't know why I typed -g, sorry, muscle memory! Looks like tests are passing now so I will merge. Thank you again! |
|
Hey @yurijmikhalevich could I please get write permissions for the NPM repo https://www.npmjs.com/package/winston-mongodb so I can push out this major release? Thanks! (I'm |
|
@yurijmikhalevich sorry to pester, but gentle bump on the above - any help is appreciated :) |
|
@DABH, done. Thank you! :) |
|
FYI @indexzero |
see #218
Changes done:
@DABH can you please have a look at this PR