Fix incorrect name of dbName option#329
Conversation
|
For some reason, some of these tests are failing – any chance you can take a look and investigate? I can’t imagine it’s related to your change, but since it seems like you are a user of this repository, you might understand what’s going on… 🙏 |
|
Should be fixed. Please trigger a CI run. |
|
@ulrichstark nice try, but not quite 🥲 Really appreciate your (and AI’s) help and anything else you can do to get this back to green :) |
|
Second attempt. Mongo v4 probably needed to be dropped from test matrix, because it depends on libcrypto.so.1.1 that's not supported by github's ubuntu runner anymore. Also took the chance to add all newer major versions of node and mongo to the test matrix and added an .editorconfig file so that my Prettier formats files of this repo in the indent style they currently are to make contributing for me and others a bit easier. Probably needs some more formatting options set to match the style of the .js files of this repo more closely, but this shouldn't be part of this PR. My conversation with ChatGPT with more details: https://chatgpt.com/share/68433bae-c2b0-8011-be2c-547b3a40877e |
|
Does 5.0 also depend on that unsupported crypto version? Perhaps it needs to be dropped too. Not sure if those Mongo versions are even supported anymore, my guess is they are past EOL |
|
Saw this nodejs/docker-node#1915 which basically says that we can install the old library version, but I don’t think that’s really what we want to do… it looks like 5.0, and 6.0 in a few weeks, will be past EOL, so I suggest we just go ahead and remove those…
|
|
(we can cut a new major version that drops support for those old versions officially…) |
|
Feel free to do those changes. I don't think I can help here anymore sorry :( |
2 participants
No description provided.