feat(Wpb-18861): Selectable tabs, conversation filters #19769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…references selector, removed old translation keys
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #19769 +/- ##
==========================================
- Coverage 43.45% 43.44% -0.01%
==========================================
Files 1294 1294
Lines 32542 32618 +76
Branches 7229 7244 +15
==========================================
+ Hits 14140 14172 +32
- Misses 16689 16728 +39
- Partials 1713 1718 +5 🚀 New features to boost your workflow:
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/2FA-for-TeamsSpecs/2fa-for-teams.spec.ts (❌ 2 failed,
|
Contributor
Author
Design update
|
nkaramarko
reviewed
Nov 21, 2025
src/script/page/LeftSidebar/panels/Conversations/ConversationTabs/ConversationTabs.tsx
Outdated
Show resolved
Hide resolved
nkaramarko
requested changes
Nov 21, 2025
| type: SidebarTabs.UNREAD, | ||
| title: t('conversationLabelUnread'), | ||
| dataUieName: 'go-unread-view', | ||
| Icon: <Icon.MarkAsUnreadIcon />, |
Collaborator
There was a problem hiding this comment.
@emil-wire MarkAsUnreadIcon is missing on Icon component and locally this breaks the app - popup shows and the only thing to do is reload, which again shows same error. Please fix
Bumps [rimraf](https://github.com/isaacs/rimraf) from 6.1.0 to 6.1.2. - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v6.1.0...v6.1.2) --- updated-dependencies: - dependency-name: rimraf dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pm2](https://github.com/Unitech/pm2) from 6.0.13 to 6.0.14. - [Release notes](https://github.com/Unitech/pm2/releases) - [Changelog](https://github.com/Unitech/pm2/blob/master/CHANGELOG.md) - [Commits](Unitech/pm2@v6.0.13...v6.0.14) --- updated-dependencies: - dependency-name: pm2 dependency-version: 6.0.14 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test(TC-34579: verify signin button is disabled inc ase of empty credentials * test(TC-3468): Verify sign in error appearance in case of suspended team account * test(TC-3460): Verify current browser is set as temporary device * test(TC-3465): Verify sign in error appearance in case of wrong credentials * test(TC-3472): Ensure history is kept after refresh on permanent device * test(TC-3473): create data driven test to also ensure history is kept on temporary device * test(TC-1311): verify session expires * test(TC-3480): check tls versions allowed by webapp server * test(TC-1311): Ensure history is gone after logging out of public computer
…19825) * fix(lifecycle): optimise online / offline event handling. Add heartbeat for WS * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <[email protected]> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <[email protected]> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <[email protected]> * chore: rename to updateConnectivityStatus * chore: add copilot suggested improvements --------- Co-authored-by: Copilot <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.21.2 to 4.22.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.22.0/History.md) - [Commits](expressjs/express@4.21.2...4.22.0) --- updated-dependencies: - dependency-name: express dependency-version: 4.22.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test(WPB-19940): add tests for blocking users * test(block): refactor block.spec.ts according to Review-Comments add function to userActions.ts to send a connection request add fixture for connection request delete conversationNotConnected.modal.ts, replace it with acknowledge.modal.ts * test(block): refactor block.spec.ts according to Review-Comments * test(block): refactor block.spec.ts according to Review-Comments * test(block): fixed unclear comments and variable namings --------- Co-authored-by: Klaus Boldt <[email protected]>
Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 2.12.0 to 2.13.0. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@v2.12.0...v2.13.0) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* initial commit * add close modal handler * added isFileEditable() * added edit option for conversation assets * add tests * fixed getNode api call * bump @webapp/core * fix package.json * fixed package.json * fix package.json * address PR comments * fixed types
Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.26.0 to 16.26.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.26.0...16.26.1) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.56.1 to 1.57.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.56.1...v1.57.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.57.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…19819) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.31 to 2.8.32. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.31...v2.8.32) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.32 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.2 to 4.16.1. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.16.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: use nvmrc to select node version * feat: add job to build test service * feat: shard tests across multiple runners with integrated testservice & job to collect reports * fix: build shadowJar of testservice * fix: generate json report when merging blobs * refactor: only download chrome browser for tests * ci: use github reporter in CI * fix: re-use playwright config when merging reports to generate json report for PR comment * refactor: don't pass github user and token when building testservice * feat: use 16 runners for sharding * feat: execute regression tests in addition to critical flow * fix: make script for reporting playwright summary work with nested test suites * chore: use SHA for third party actions (So Sonar shuts up) * refactor: use line reporter instead of github The report annotations are too annoying * refactor: stop background process of testservice after test * fix: run critical flow and regression tests * ci: increase number of parallel test runners to 32 Now that the regression tests and critical flow tests are executed 16 runners is a bit too little * style: ignore prettier for shard definition * chore: safe guard stripAnsi function in report generation
* refactor: update report script to group tests by file * style: use list to render test cases * feat: add direct link to download playwright report
|
EnricoSchw
previously requested changes
Dec 3, 2025
emil-wire
dismissed
EnricoSchw’s stale review
Reviewed changes not done by me
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user selectable conversation filters + tabs
This PR is a rewrite of a previous PR that didn't work out so well. Using the feature flag FEATURE_ENABLE_ADVANCED_FILTERS you can turn this on and test it.
Checklist