refactor(WPB-21957): create fixture for creating teams + refactor edit tests with it

[markbrockhoff]

WPB-21957 [Web/QA] Add fixture for creating teams

Pull Request

Summary

This PR adds a new fixture to create a team owner with a team and the option to add members to it. This was mainly done to avoid the race condition which can occur when connecting users via the api. Using a team eliminates the need to send a connection request first.

---

Security Checklist (required)

• External inputs are validated & sanitized on client and/or server where applicable.
• API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
• No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
• Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Standards Acknowledgement (required)

• I have read and this PR upholds our Coding Standards and Tech Radar Choices.

---

Notes for reviewers

• Trade-offs:
• Follow-ups (linked issues):
• Linked PRs (e.g. web-packages): test(WPB-19966): write "Reply" regression tests #19760

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.46%. Comparing base (59de699) to head (4482fae).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #19804      +/-   ##
==========================================
+ Coverage   43.45%   43.46%   +0.01%     
==========================================
  Files        1294     1294              
  Lines       32544    32544              
  Branches     7230     7230              
==========================================
+ Hits        14141    14146       +5     
+ Misses      16691    16687       -4     
+ Partials     1712     1711       -1     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

• ✅ Passed: 8
• ❌ Failed: 3
• ⏭ Skipped: 0
• 🔁 Flaky: 3
• 📊 Total: 14
• ⏱ Total Runtime: 1000.3s (~ 16 min 40 sec)

Failed Tests:

❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 31883ms

Errors:

Error: expect(received).toBeFalsy()

Received: true

  122 |       await memberCalling.unmuteSelfInFullScreen();
  123 |       await memberPageManager.waitForTimeout(250);
> 124 |       expect(await memberCalling.isSelfUserMutedInFullScreen()).toBeFalsy();
      |                                                                 ^
  125 |     });
  126 |
  127 |     await test.step('Validation: Owner sees member is unmuted', async () => {
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:124:65
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:121:5

❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 42321ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('#add-participants [data-uie-name="search-list"] [aria-label="Open profile of Camron Boyer"]').locator('input[type="checkbox"]')


   at pageManager/webapp/pages/conversationDetails.page.ts:66

  64 |       await userLocator.click();
  65 |       // Wait for the user to be selected (checkbox should be checked)
> 66 |       await userLocator.locator('input[type="checkbox"]').waitFor({state: 'attached'});
     |                                                           ^
  67 |     }
  68 |
  69 |     await this.page.locator(`${selectById('add-participants')} ${selectByDataAttribute('do-create')}`).click();
    at ConversationDetailsPage.addUsersToConversation (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversationDetails.page.ts:66:59)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:127:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:123:5

❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)

Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:38
Duration: 66976ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('#add-participants [data-uie-name="search-list"] [aria-label="Open profile of Bernie Johns"]').locator('input[type="checkbox"]')


   at pageManager/webapp/pages/conversationDetails.page.ts:66

  64 |       await userLocator.click();
  65 |       // Wait for the user to be selected (checkbox should be checked)
> 66 |       await userLocator.locator('input[type="checkbox"]').waitFor({state: 'attached'});
     |                                                           ^
  67 |     }
  68 |
  69 |     await this.page.locator(`${selectById('add-participants')} ${selectByDataAttribute('do-create')}`).click();
    at ConversationDetailsPage.addUsersToConversation (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversationDetails.page.ts:66:59)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:125:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:114:5

Flaky Tests:

⚠️ Account Management (tags: TC-8639, crit-flow-web)

Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37

Attempt 1
Result: ❌ Failed
Duration: 84417ms

Errors:

Error: Matching URL not found in the email body

   at backend/inbucketClient.e2e.ts:120

  118 |
  119 |     if (this.isValidURL(matchingUrl) === false) {
> 120 |       throw new Error('Matching URL not found in the email body');
      |             ^
  121 |     }
  122 |
  123 |     return matchingUrl;
    at InbucketClientE2E.getMatchingURLFromEmailBody (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/backend/inbucketClient.e2e.ts:120:13)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:133:30
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:124:3

Attempt 2
Result: ✅ Passed
Duration: 29518ms

⚠️ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:39

Attempt 1
Result: ❌ Failed
Duration: 62788ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-call"]') to be visible


   at pageManager/webapp/pages/calling.page.ts:90

  88 |
  89 |   waitForCell(): Promise<void> {
> 90 |     return this.callCell.waitFor({state: 'visible'});
     |                          ^
  91 |   }
  92 |
  93 |   isFullScreenVisible(): Promise<boolean> {
    at CallingPage.waitForCell (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/calling.page.ts:90:26)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:99:34
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:97:16

Attempt 2
Result: ✅ Passed
Duration: 78669ms

⚠️ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)

Location: specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:31

Attempt 1
Result: ❌ Failed
Duration: 1094ms

Errors:

AxiosError: Request failed with status code 409

   at backend/userRepository.e2e.ts:35

  33 |
  34 |   public async setUniqueUsername(username: string, token: string) {
> 35 |     await this.axiosInstance.put(
     |     ^
  36 |       'self/handle',
  37 |       {handle: username},
  38 |       {
    at settle (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/node_modules/axios/lib/core/settle.js:19:12)
    at Unzip.handleStreamEnd (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/node_modules/axios/lib/adapters/http.js:599:11)
    at Axios.request (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/node_modules/axios/lib/core/Axios.js:45:41)
    at UserRepositoryE2E.setUniqueUsername (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/backend/userRepository.e2e.ts:35:5)
    at ApiManagerE2E.createPersonalUser (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/backend/apiManager.e2e.ts:100:5)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:47:9
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:45:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:44:3

Attempt 2
Result: ✅ Passed
Duration: 52239ms

[Copilot]

Pull request overview

This PR refactors E2E tests by introducing a new createTeam fixture that simplifies team-based test setup and eliminates race conditions from API-based user connections. The fixture allows creating a team owner with optional members, providing a more reliable testing approach for team scenarios.

Key Changes

• Added createTeam fixture to create teams with owners and members programmatically
• Introduced connectWithUser utility and withConnectedUser plugin for team-based user connections
• Refactored edit.spec.ts tests to use the new team fixture instead of the previous user-connection approach
• Added supporting API methods for team operations (upgradeUserToTeamOwner, acceptTeamInvitation)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
test/e2e_tests/test.fixtures.ts	Added createTeam fixture with team creation and member invitation logic; added withConnectedUser plugin; extracted createUser helper function
test/e2e_tests/specs/Edit/edit.spec.ts	Refactored all tests to use createTeam fixture and withConnectedUser instead of createUser with api.connectUsers
test/e2e_tests/utils/userActions.ts	Added connectWithUser utility for team-based connections; removed German comment
test/e2e_tests/backend/teamRepository.e2e.ts	Added acceptTeamInvitation method for team member onboarding
test/e2e_tests/backend/authRepository.e2e.ts	Added upgradeUserToTeamOwner method to convert personal users to team owners
test/e2e_tests/backend/backendClient.e2e.ts	Changed from MINIMUM_API_VERSION import to hardcoded v13

Comments suppressed due to low confidence (1)

test/e2e_tests/backend/authRepository.e2e.ts:100

• [Important] Missing input validation for teamName parameter. The teamName is passed directly to the API without validation, which could lead to unexpected API errors if empty, too long, or containing invalid characters.

Suggestion: Add validation before the API call:

if (!teamName || teamName.trim().length === 0) {
  throw new Error('Team name cannot be empty');
}

  async upgradeUserToTeamOwner(user: User, teamName: string) {
    const res = this.axiosInstance.post(
      'upgrade-personal-to-team',
      {
        name: teamName,
        icon: 'default',
      },
      {
        headers: {
          Authorization: `Bearer ${user.token}`,
        },
      },
    );
    const data = (await res).data;
    return {teamId: data.team_id, teamName: data.team_name};
  }

  public async activateAccount(email: string, code: string) {
    await this.axiosInstance.post('activate', {
      code,
      dryrun: false,
      email: email,
    });
  }

  public async bookEmail(email: string) {
    await this.axiosInstance.post('activate/send', {
      email: email,
    });
  }

  public async loginUser(user: User): Promise<AxiosResponse> {
    const response = await this.axiosInstance.post(
      'login',
      {

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.9% Duplication on New Code

See analysis details on SonarQube Cloud