Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Dec 3, 2025

BugWPB-21715 Tapping call join button repeatedly leads to incorrect state

Summary

Add guard on join/call buttons on CallingCell.tsx, TitleBar.tsx and ConversationList.tsx.
Clicking on join/call button multiple times will not try to connect call multiple times.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Standards Acknowledgement (required)

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 45.00000% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.73%. Comparing base (f4096cb) to head (f236311).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #19837   +/-   ##
=======================================
  Coverage   43.73%   43.73%           
=======================================
  Files        1298     1299    +1     
  Lines       32696    32744   +48     
  Branches     7258     7268   +10     
=======================================
+ Hits        14298    14320   +22     
- Misses      16682    16703   +21     
- Partials     1716     1721    +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 77
  • Failed: 22
  • Skipped: 5
  • 🔁 Flaky: 5
  • 📊 Total: 109
  • Total Runtime: 465.2s (~ 7 min 45 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 2 failed, ⚠️ 0 flaky)
  • ❌ Accessibility > I want to see collapsed view when app is narrow (tags: TC-48, regression)
  • ❌ Accessibility > I should not lose a drafted message when switching between conversations in collapsed view (tags: TC-51, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 2 failed, ⚠️ 1 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
  • ❌ account settings > Verify links to manage and create teams are shown when logged in as team owner (tags: TC-1723, regression)
  • ⚠️ account settings > I should not be able to change my email to an invalid email address (tags: TC-59, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/Authentication/authentication.spec.ts (❌ 6 failed, ⚠️ 0 flaky)
  • ❌ Authentication > Verify sign in error appearance in case of suspended team account (tags: TC-3468, regression)
  • ❌ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
  • ❌ Authentication > Verify sign in error appearance in case of wrong credentials (tags: TC-3465, regression)
  • ❌ Authentication > I want to keep my history after refreshing the page on temporary device (tags: TC-3473, regression)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
  • ❌ Authentication > Verify session expired info is visible on login page (tags: TC-1311, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you still receive messages from blocked person in a group chat (tags: TC-141, regression)
specs/Connections/Connections.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Connections > Verify 1on1 conversation is not created on the second end after you ignore connection request (tags: TC-365, TC-369, TC-370, TC-371, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/channelsManagement-TC-8752.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Channels Management (tags: TC-8752, crit-flow-web)
specs/CriticalFlow/groupCalls-TC-8632.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)
specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Group Video call (tags: TC-8637, crit-flow-web)
specs/CriticalFlow/joinTeam-TC-8635.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)
specs/Edit/edit.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Edit > I see changed message if message was edited from another device (tags: TC-682, regression)
specs/LoginSpecs/login.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Verify you can sign in by email (tags: TC-3461, regression)
specs/RegressionSpecs/block-messages.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block specs (tags: TC-141, regression)
specs/Reply/reply.spec.ts (❌ 0 failed, ⚠️ 3 flaky)
  • ⚠️ Reply > I should not be able to reply to a ping (tags: TC-8038, regression)
  • ⚠️ Reply > I want to send a timed message as a reply to any type of a message (tags: TC-3011, regression)
  • ⚠️ Reply > I want to click the quoted message to jump to the original message (tags: TC-3013, regression)

@zskhan zskhan force-pushed the fix/tapping-join-btn-repeatedly branch 2 times, most recently from 65c67df to 4604632 Compare December 3, 2025 17:30
Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zskhan zskhan force-pushed the fix/tapping-join-btn-repeatedly branch from 4604632 to f236311 Compare December 4, 2025 15:01
@zskhan zskhan enabled auto-merge (squash) December 4, 2025 15:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@zskhan zskhan merged commit b8da03e into dev Dec 4, 2025
11 of 12 checks passed
@zskhan zskhan deleted the fix/tapping-join-btn-repeatedly branch December 4, 2025 15:05
aweiss-dev pushed a commit that referenced this pull request Dec 8, 2025
* fix: add guard on join/call buttons.

* fix: return empty cleanup method
zskhan added a commit that referenced this pull request Dec 12, 2025
* fix: add guard on join/call buttons.

* fix: return empty cleanup method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants