-
Notifications
You must be signed in to change notification settings - Fork 298
fix: add guard on join/call buttons [WPB-21715]. #19837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #19837 +/- ##
=======================================
Coverage 43.73% 43.73%
=======================================
Files 1298 1299 +1
Lines 32696 32744 +48
Branches 7258 7268 +10
=======================================
+ Hits 14298 14320 +22
- Misses 16682 16703 +21
- Partials 1716 1721 +5 🚀 New features to boost your workflow:
|
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/Accessibility/Accessibility.spec.ts (❌ 2 failed,
|
65c67df to
4604632
Compare
e-maad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
4604632 to
f236311
Compare
|
* fix: add guard on join/call buttons. * fix: return empty cleanup method
* fix: add guard on join/call buttons. * fix: return empty cleanup method




Summary
Add guard on join/call buttons on
CallingCell.tsx,TitleBar.tsxandConversationList.tsx.Clicking on join/call button multiple times will not try to connect call multiple times.
Security Checklist (required)
Standards Acknowledgement (required)