Skip to content

Conversation

@ooga
Copy link
Contributor

@ooga ooga commented Nov 13, 2025

Changes

  • add command and commandfor into ButtonHTMLAttributes

Testing

Copied from svelte repo and manually tested the change in a local project

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: aa565b7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

📝 Changeset Validation Results

Changeset validation failed

Issues Found:

.changeset/fifty-baboons-bow.md

Issue with: 'Adds command and commandfor to the attribute that can be passed to the button element'

❌ The description suggests a new feature, which corresponds to a 'minor' change type, not 'patch'.

💡 Update the changeset file to reflect the correct 'minor' change type: ```yaml

'astro': minor
---```


📖 See Astro's changeset guide for details.

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florian-lefebvre florian-lefebvre merged commit 345eb22 into withastro:main Nov 24, 2025
4 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants