This repository was archived by the owner on Oct 11, 2022. It is now read-only.
fix(ToggleChannelNotifications): improve toggle notification icon consistency #5378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why |
brianlovin
reviewed
Jul 22, 2020
| @@ -151,10 +151,9 @@ const Channel = (props: Props) => { | |||
| <Tooltip content={tipText}> | |||
| <span style={{ marginLeft: '8px', display: 'flex' }}> | |||
| <OutlineButton | |||
| disabled={isLoading} | |||
There was a problem hiding this comment.
If we remove this, the user could double click and we might end up with some race conditions on network requests, right? Is there any way to preserve this?
There was a problem hiding this comment.
I decided to remove the disabled prop because in reality it is not preventing the double click right now. The component with the onClick functionality is ToggleChannelNotifications that is the parent of the button. The disabled at the moment is only giving the opacity effect.
Current app functionality
There was a problem hiding this comment.
I could also prevent that in this PR if you want.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Problem description
The problem is that a disabled button doesn't fire the
onMouseLeaveevent (more here), preventingisHoveringNotificationsbeing set tofalse.Related issues (delete if you don't know of any)
Closes #5369