Skip to content

Conversation

@Adammatthiesen
Copy link
Member

@Adammatthiesen Adammatthiesen commented Apr 13, 2025

Description

  • Closes #
  • What does this PR change? Give us a brief description.

Summary by CodeRabbit

  • New Features

    • Enhanced localization: Social sharing titles on the dashboard now support multiple languages including English, German, Spanish, and French.
  • Chores

    • Updated dependencies and bumped the StudioCMS version to beta.15.
    • Streamlined internal processes by consolidating module imports and cleaning up legacy utilities.

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2025

🦋 Changeset detected

Latest commit: 5d723a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@studiocms/socialposter Patch
@studiocms/wysiwyg Patch
@studiocms/grapesjs-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 13, 2025

Walkthrough

This update introduces new changeset files that trigger patch updates for the @studiocms/socialposter and @studiocms/wysiwyg packages, and raises the minimum StudioCMS version to beta.15. In addition, the studiocmsSocialPoster function is updated with a version bump and enhanced localization support. The WYSIWYG package now imports its runtime utilities via an absolute path, and several runtime and decoder files used for component proxying and HTML/XML decoding have been removed. Dependency versions in the workspace configuration have also been updated.

Changes

File(s) Change Summary
.changeset/blue-buses-doubt.md, .changeset/strong-dancers-crash.md New changeset files added to mark patch updates for @studiocms/socialposter and @studiocms/wysiwyg and to update the minimum StudioCMS version to beta.15.
packages/studiocms_socialposter/src/index.ts Updated the studiocmsSocialPoster function: bumped minimum version from beta.14 to beta.15 and modified dashboard localization keys (replacing "en-us" with "en"; adding "de", "es", and "fr").
packages/studiocms_wysiwyg/src/common/prepareRender.ts Modified the import statement to use an absolute path from studiocms/runtime instead of a relative path.
packages/studiocms_wysiwyg/src/runtime/{AstroComponentProxy.ts, decoder/**} Removed multiple files: the component proxy file and a set of decoder files (decode-codepoint.ts, decode-data-html.ts, decode-data-xml.ts, index.ts, util.ts) responsible for entity and Unicode decoding.
pnpm-workspace.yaml Updated dependency versions for several packages and min catalog entries (e.g., @astrojs/db, @studiocms/blog, @studiocms/devapps, astro, sharp, studiocms, and vite) to newer versions reflecting the beta.15 release.

Possibly related PRs

Suggested reviewers

  • dreyfus92
  • RATIU5
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/withstudiocms/experiments/@studiocms/grapesjs-plugin@12
npm i https://pkg.pr.new/withstudiocms/experiments/@studiocms/socialposter@12
npm i https://pkg.pr.new/withstudiocms/experiments/@studiocms/wysiwyg@12

commit: 5d723a7

@Adammatthiesen Adammatthiesen marked this pull request as ready for review April 13, 2025 08:47
@Adammatthiesen Adammatthiesen requested a review from a team as a code owner April 13, 2025 08:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/studiocms_socialposter/src/index.ts (1)

47-51: Improved internationalization support needs translations.

While the code now supports multiple languages (en, de, es, fr), all translations currently use the same English text. Consider providing appropriate translations for each language to fully leverage this internationalization enhancement.

 title: {
   en: 'Share to Social Media',
-  de: 'Share to Social Media',
-  es: 'Share to Social Media',
-  fr: 'Share to Social Media',
+  de: 'In sozialen Medien teilen',
+  es: 'Compartir en redes sociales',
+  fr: 'Partager sur les réseaux sociaux',
 },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8325a2 and 5d723a7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • .changeset/blue-buses-doubt.md (1 hunks)
  • .changeset/strong-dancers-crash.md (1 hunks)
  • packages/studiocms_socialposter/src/index.ts (1 hunks)
  • packages/studiocms_wysiwyg/src/common/prepareRender.ts (1 hunks)
  • packages/studiocms_wysiwyg/src/runtime/AstroComponentProxy.ts (0 hunks)
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-codepoint.ts (0 hunks)
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-html.ts (0 hunks)
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-xml.ts (0 hunks)
  • packages/studiocms_wysiwyg/src/runtime/decoder/index.ts (0 hunks)
  • packages/studiocms_wysiwyg/src/runtime/decoder/util.ts (0 hunks)
  • pnpm-workspace.yaml (1 hunks)
💤 Files with no reviewable changes (6)
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-xml.ts
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-html.ts
  • packages/studiocms_wysiwyg/src/runtime/AstroComponentProxy.ts
  • packages/studiocms_wysiwyg/src/runtime/decoder/index.ts
  • packages/studiocms_wysiwyg/src/runtime/decoder/decode-codepoint.ts
  • packages/studiocms_wysiwyg/src/runtime/decoder/util.ts
🔇 Additional comments (6)
.changeset/strong-dancers-crash.md (1)

1-5: Clear versioning documentation.

The changeset correctly specifies a patch update for the @studiocms/socialposter package and clearly documents that the minimum required StudioCMS version is now beta.15, which aligns with the changes in other files.

pnpm-workspace.yaml (2)

2-11: Consistent version updates across dependencies.

All StudioCMS-related packages have been correctly updated to beta.15, with complementary updates to other dependencies like astro (5.6) and sharp (0.34.0). The version increments follow a coherent pattern and maintain compatibility across the ecosystem.


17-20: Aligned minimum catalog versions.

The minimum catalog versions have been correctly updated to match the main catalog, ensuring consistent version requirements across different build environments.

.changeset/blue-buses-doubt.md (1)

1-6: Comprehensive changeset for multiple packages.

This changeset appropriately documents patch updates for both the @studiocms/socialposter and @studiocms/wysiwyg packages, with a clear note about the StudioCMS beta.15 update. This complements the other changeset file and ensures all affected packages are properly tracked.

packages/studiocms_socialposter/src/index.ts (1)

42-42: Version correctly updated.

The studiocmsMinimumVersion has been properly updated to '0.1.0-beta.15', aligning with the changes in the changeset files and workspace configuration.

packages/studiocms_wysiwyg/src/common/prepareRender.ts (1)

6-6: Absolute Import Update
The change from a relative import to an absolute import (from 'studiocms/runtime') for createComponentProxy and transformHTML clearly aligns with the broader refactoring goals outlined in the PR. This approach improves module resolution and centralizes the runtime utilities, ensuring consistency across the codebase.

@Adammatthiesen Adammatthiesen changed the title Update StudioCMS Update StudioCMS deps Apr 13, 2025
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Adammatthiesen Adammatthiesen merged commit 848df9e into main Apr 14, 2025
11 checks passed
@Adammatthiesen Adammatthiesen deleted the update branch April 14, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants