-
-
Notifications
You must be signed in to change notification settings - Fork 2
Update StudioCMS deps #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5d723a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update introduces new changeset files that trigger patch updates for the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/studiocms_socialposter/src/index.ts (1)
47-51: Improved internationalization support needs translations.While the code now supports multiple languages (en, de, es, fr), all translations currently use the same English text. Consider providing appropriate translations for each language to fully leverage this internationalization enhancement.
title: { en: 'Share to Social Media', - de: 'Share to Social Media', - es: 'Share to Social Media', - fr: 'Share to Social Media', + de: 'In sozialen Medien teilen', + es: 'Compartir en redes sociales', + fr: 'Partager sur les réseaux sociaux', },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.changeset/blue-buses-doubt.md(1 hunks).changeset/strong-dancers-crash.md(1 hunks)packages/studiocms_socialposter/src/index.ts(1 hunks)packages/studiocms_wysiwyg/src/common/prepareRender.ts(1 hunks)packages/studiocms_wysiwyg/src/runtime/AstroComponentProxy.ts(0 hunks)packages/studiocms_wysiwyg/src/runtime/decoder/decode-codepoint.ts(0 hunks)packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-html.ts(0 hunks)packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-xml.ts(0 hunks)packages/studiocms_wysiwyg/src/runtime/decoder/index.ts(0 hunks)packages/studiocms_wysiwyg/src/runtime/decoder/util.ts(0 hunks)pnpm-workspace.yaml(1 hunks)
💤 Files with no reviewable changes (6)
- packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-xml.ts
- packages/studiocms_wysiwyg/src/runtime/decoder/decode-data-html.ts
- packages/studiocms_wysiwyg/src/runtime/AstroComponentProxy.ts
- packages/studiocms_wysiwyg/src/runtime/decoder/index.ts
- packages/studiocms_wysiwyg/src/runtime/decoder/decode-codepoint.ts
- packages/studiocms_wysiwyg/src/runtime/decoder/util.ts
🔇 Additional comments (6)
.changeset/strong-dancers-crash.md (1)
1-5: Clear versioning documentation.The changeset correctly specifies a patch update for the
@studiocms/socialposterpackage and clearly documents that the minimum required StudioCMS version is now beta.15, which aligns with the changes in other files.pnpm-workspace.yaml (2)
2-11: Consistent version updates across dependencies.All StudioCMS-related packages have been correctly updated to beta.15, with complementary updates to other dependencies like astro (5.6) and sharp (0.34.0). The version increments follow a coherent pattern and maintain compatibility across the ecosystem.
17-20: Aligned minimum catalog versions.The minimum catalog versions have been correctly updated to match the main catalog, ensuring consistent version requirements across different build environments.
.changeset/blue-buses-doubt.md (1)
1-6: Comprehensive changeset for multiple packages.This changeset appropriately documents patch updates for both the
@studiocms/socialposterand@studiocms/wysiwygpackages, with a clear note about the StudioCMS beta.15 update. This complements the other changeset file and ensures all affected packages are properly tracked.packages/studiocms_socialposter/src/index.ts (1)
42-42: Version correctly updated.The
studiocmsMinimumVersionhas been properly updated to '0.1.0-beta.15', aligning with the changes in the changeset files and workspace configuration.packages/studiocms_wysiwyg/src/common/prepareRender.ts (1)
6-6: Absolute Import Update
The change from a relative import to an absolute import (from'studiocms/runtime') forcreateComponentProxyandtransformHTMLclearly aligns with the broader refactoring goals outlined in the PR. This approach improves module resolution and centralizes the runtime utilities, ensuring consistency across the codebase.
dreyfus92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Description
Summary by CodeRabbit
New Features
Chores