Skip to content

fix: remove database isolate #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

parodyBit
Copy link
Contributor

@parodyBit parodyBit commented May 11, 2025

call databaseService directly from ApiDatabase
moved encode and decode of keychain to CryptoIsolate
close #655

@parodyBit parodyBit requested review from gabaldon and Tommytrg May 11, 2025 18:29
@Tommytrg Tommytrg mentioned this pull request May 12, 2025
AccountStats: statsRepository.updateStats,
};
if (repoMap.keys.contains(item.runtimeType)) {
return await repoMap[item.runtimeType](key, item, database);
Copy link
Contributor

@gabaldon gabaldon May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error shows when changing wallet

Found: AccountRepository.updateAccount(Account, DatabaseClient) => Future<bool>
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:38:5)
#1      _objectNoSuchMethod (dart:core-patch/object_patch.dart:88:9)
#2      DatabaseService.update (package:my_wit_wallet/util/storage/database/database_service.dart:174:45)
#3      ApiDatabase.updateAccount (package:my_wit_wallet/shared/api_database.dart:310:21)
#4      Wallet.updateAccount (package:my_wit_wallet/util/storage/database/wallet.dart:593:18)
#5      ExplorerBloc.syncWalletStorage (package:my_wit_wallet/bloc/explorer/explorer_bloc.dart:502:16)
#6      ExplorerBloc.syncWalletRoutine (package:my_wit_wallet/bloc/explorer/explorer_bloc.dart:554:17)
<asynchronous suspension>
#7      ExplorerBloc._singleSyncEvent (package:my_wit_wallet/bloc/explorer/explorer_bloc.dart:136:38)
<asynchronous suspension>
#8      ExplorerBloc._syncWalletEvent (package:my_wit_wallet/bloc/explorer/explorer_bloc.dart:150:7)
<asynchronous suspension>
#9      Bloc.on.<anonymous closure>.handleEvent (package:bloc/src/bloc.dart:229:13)
<asynchronous suspension>

@gabaldon gabaldon mentioned this pull request May 26, 2025
parodyBit added 2 commits May 27, 2025 05:50
call databaseService directly from ApiDatabase
moved encode and decode of keychain to CryptoIsolate
@parodyBit parodyBit force-pushed the remove-DatabaseIsolate branch from 8a97c46 to 8ec9c73 Compare May 27, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix windows release
2 participants