Skip to content

Error when config doesn't exist, issue #118 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Error when config doesn't exist, issue #118 #119

merged 1 commit into from
Nov 24, 2015

Conversation

witoldsz
Copy link
Owner

No description provided.

@pjfreeze
Copy link

I'd love to see this merged in, are you waiting on anything in particular to merge in and create a release?

@simison
Copy link
Contributor

simison commented Nov 19, 2015

@pjfreeze might be just requires thumbs up from me or you. :-) #118 (comment)

Wanna test this? I'm on holidays.

@witoldsz
Copy link
Owner Author

@simison is right, I mean it would be great if you could confirm the new code fixes the issue.

@pjfreeze
Copy link

@simison @witoldsz Looks good to me. I've included 2 links, let me know if you have any questions or issues with that test case

Not working with version angular-http-auth#1.2.2
http://codepen.io/anon/pen/zvQBom

Working with angular-http-auth#issue-118
http://codepen.io/anon/pen/epazgK

I borrowed the test case from a comment on the related issue simison linked to from #118:

rcollette commented on Jul 17
Just to show where this scenario can occur without any other interceptors defined.

I had a case where a configured URL was not specified resulting in a null url parameter being passed to $http.post. The result is an infinite loading bar.

See example here:
http://plnkr.co/edit/YhsWp7G4L1Gh93v1fsTJ?p=preview

witoldsz added a commit that referenced this pull request Nov 24, 2015
Error when config doesn't exist, issue #118
@witoldsz witoldsz merged commit 9f70c45 into master Nov 24, 2015
@simison
Copy link
Contributor

simison commented Nov 24, 2015

Thanks @witoldsz & @pjfreeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants