Skip to content

Docs - Added figma embed links for missing pages #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Apr 27, 2025

Description

Add missing pages to with figma embed

Changelog

N/A

Additional info

MADS-4671

@nitzanyiz nitzanyiz changed the title Docs/embed figma pages Docs - Added figma embed links for missing pages Apr 27, 2025
@nitzanyiz nitzanyiz marked this pull request as ready for review April 27, 2025 12:57
"docs": {
"hero": {
"title": "WheelPicker",
"description": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take the description from this file as a default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to remove the "description"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I mean to set the description from this file. Every api json has a "description" field that describs the component. If we don't have one from the UX we can add our in as default. WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, got you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we would want this by default. I feel like this is the only usage that it will be used and there would pages we might not want that... Do you think we should use the descriptions as a default value for the hero section? Programmatically in the ComponentPage file... (Or just add it one time here)

@nitzanyiz nitzanyiz merged commit 27e1cfa into master Apr 28, 2025
1 check passed
@nitzanyiz nitzanyiz deleted the docs/embed-figma-pages branch April 28, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants