-
Notifications
You must be signed in to change notification settings - Fork 734
Docs - Added figma embed links for missing pages #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"docs": { | ||
"hero": { | ||
"title": "WheelPicker", | ||
"description": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we take the description from this file as a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to remove the "description"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I mean to set the description from this file. Every api json has a "description" field that describs the component. If we don't have one from the UX we can add our in as default. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, got you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we would want this by default. I feel like this is the only usage that it will be used and there would pages we might not want that... Do you think we should use the descriptions as a default value for the hero section? Programmatically in the ComponentPage file... (Or just add it one time here)
Description
Add missing pages to with figma embed
Changelog
N/A
Additional info
MADS-4671